PR feedback

cte · cte · commit 248a8c2972c2 · 2025-11-10T14:37:59.000-08:00
diff --git a/src/core/auto-approval/__tests__/AutoApprovalHandler.spec.ts b/src/core/auto-approval/__tests__/AutoApprovalHandler.spec.ts
@@ -1,8 +1,7 @@
 import { GlobalState, ClineMessage } from "@roo-code/types"
 
-import { AutoApprovalHandler } from "../../auto-approval/AutoApprovalHandler"
+import { AutoApprovalHandler } from "../AutoApprovalHandler"
 
-// Mock getApiMetrics
 vi.mock("../../../shared/getApiMetrics", () => ({
 	getApiMetrics: vi.fn(),
 }))
diff --git a/src/core/auto-approval/index.ts b/src/core/auto-approval/index.ts
@@ -60,7 +60,7 @@ export async function isAutoApproved({
 			const mcpServerUse = JSON.parse(text) as McpServerUse
 
 			if (mcpServerUse.type === "use_mcp_tool") {
-				return state.alwaysAllowMcp === true && isMcpToolAlwaysAllowed(text, state.mcpServers)
+				return state.alwaysAllowMcp === true && isMcpToolAlwaysAllowed(mcpServerUse, state.mcpServers)
 			} else if (mcpServerUse.type === "access_mcp_resource") {
 				return state.alwaysAllowMcp === true
 			}
diff --git a/src/core/auto-approval/mcp.ts b/src/core/auto-approval/mcp.ts
@@ -2,9 +2,7 @@ import type { McpServerUse } from "@roo-code/types"
 
 import type { McpServer, McpTool } from "../../shared/mcp"
 
-export function isMcpToolAlwaysAllowed(text: string, mcpServers: McpServer[] | undefined): boolean {
-	const mcpServerUse = JSON.parse(text) as McpServerUse
-
+export function isMcpToolAlwaysAllowed(mcpServerUse: McpServerUse, mcpServers: McpServer[] | undefined): boolean {
 	if (mcpServerUse.type === "use_mcp_tool" && mcpServerUse.toolName) {
 		const server = mcpServers?.find((s: McpServer) => s.name === mcpServerUse.serverName)
 		const tool = server?.tools?.find((t: McpTool) => t.name === mcpServerUse.toolName)

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ export async function isAutoApproved({`
`60`	`60`	`const mcpServerUse = JSON.parse(text) as McpServerUse`
`61`	`61`
`62`	`62`	`if (mcpServerUse.type === "use_mcp_tool") {`
`63`		`- return state.alwaysAllowMcp === true && isMcpToolAlwaysAllowed(text, state.mcpServers)`
	`63`	`+ return state.alwaysAllowMcp === true && isMcpToolAlwaysAllowed(mcpServerUse, state.mcpServers)`
`64`	`64`	`} else if (mcpServerUse.type === "access_mcp_resource") {`
`65`	`65`	`return state.alwaysAllowMcp === true`
`66`	`66`	`}`