Fix: Use api.getModel() directly instead of cachedStreamingModel

daniel-lxs · daniel-lxs · commit 1bd757e2889a · 2025-11-20T20:11:42.000-05:00
Addresses review comment: cachedStreamingModel is set during streaming but
buildCleanConversationHistory is called before streaming starts. Using the
cached value could cause stale model info when switching models between requests.

Now directly uses this.api.getModel().info.preserveReasoning to ensure we
always check the current model's flag, not a potentially stale cached value.
diff --git a/src/core/task/Task.ts b/src/core/task/Task.ts
@@ -3437,8 +3437,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					// Check if the model's preserveReasoning flag is set
 					// If true, include the reasoning block in API requests
 					// If false/undefined, strip it out (stored for history only, not sent back to API)
-					const modelInfo = this.cachedStreamingModel?.info ?? this.api.getModel().info
-					const shouldPreserveForApi = modelInfo.preserveReasoning === true
+					// Note: Use api.getModel() directly instead of cachedStreamingModel since
+					// buildCleanConversationHistory is called before streaming starts
+					const shouldPreserveForApi = this.api.getModel().info.preserveReasoning === true
 					let assistantContent: Anthropic.Messages.MessageParam["content"]
 
 					if (shouldPreserveForApi) {
