test(code-index): add tests for text-embedding-004 dimension lookup in embeddingModels

roomote · roomote · commit 04b4a69723de · 2026-01-28T04:58:35.000Z
Adds comprehensive tests for embeddingModels.ts to verify:
- text-embedding-004 is present in gemini profiles for backward compatibility
- getModelDimension returns 3072 for deprecated text-embedding-004
- Ensures createVectorStore works for users with text-embedding-004 configured
diff --git a/src/shared/__tests__/embeddingModels.spec.ts b/src/shared/__tests__/embeddingModels.spec.ts
@@ -0,0 +1,95 @@
+import { describe, it, expect } from "vitest"
+import {
+	getModelDimension,
+	getModelScoreThreshold,
+	getDefaultModelId,
+	EMBEDDING_MODEL_PROFILES,
+} from "../embeddingModels"
+
+describe("embeddingModels", () => {
+	describe("EMBEDDING_MODEL_PROFILES", () => {
+		it("should have gemini provider with gemini-embedding-001 model", () => {
+			const geminiProfiles = EMBEDDING_MODEL_PROFILES.gemini
+			expect(geminiProfiles).toBeDefined()
+			expect(geminiProfiles!["gemini-embedding-001"]).toBeDefined()
+			expect(geminiProfiles!["gemini-embedding-001"].dimension).toBe(3072)
+		})
+
+		it("should have deprecated text-embedding-004 in gemini profiles for backward compatibility", () => {
+			// This is critical for backward compatibility:
+			// Users with text-embedding-004 configured need dimension lookup to work
+			// even though the model is migrated to gemini-embedding-001 in GeminiEmbedder
+			const geminiProfiles = EMBEDDING_MODEL_PROFILES.gemini
+			expect(geminiProfiles).toBeDefined()
+			expect(geminiProfiles!["text-embedding-004"]).toBeDefined()
+			expect(geminiProfiles!["text-embedding-004"].dimension).toBe(3072)
+		})
+	})
+
+	describe("getModelDimension", () => {
+		it("should return dimension for gemini-embedding-001", () => {
+			const dimension = getModelDimension("gemini", "gemini-embedding-001")
+			expect(dimension).toBe(3072)
+		})
+
+		it("should return dimension for deprecated text-embedding-004", () => {
+			// This ensures createVectorStore() works for users with text-embedding-004 configured
+			// The dimension should be 3072 (matching gemini-embedding-001) because:
+			// 1. GeminiEmbedder migrates text-embedding-004 to gemini-embedding-001
+			// 2. gemini-embedding-001 produces 3072-dimensional embeddings
+			// 3. Vector store dimension must match the actual embedding dimension
+			const dimension = getModelDimension("gemini", "text-embedding-004")
+			expect(dimension).toBe(3072)
+		})
+
+		it("should return undefined for unknown model", () => {
+			const dimension = getModelDimension("gemini", "unknown-model")
+			expect(dimension).toBeUndefined()
+		})
+
+		it("should return undefined for unknown provider", () => {
+			const dimension = getModelDimension("unknown-provider" as any, "some-model")
+			expect(dimension).toBeUndefined()
+		})
+
+		it("should return correct dimensions for openai models", () => {
+			expect(getModelDimension("openai", "text-embedding-3-small")).toBe(1536)
+			expect(getModelDimension("openai", "text-embedding-3-large")).toBe(3072)
+			expect(getModelDimension("openai", "text-embedding-ada-002")).toBe(1536)
+		})
+	})
+
+	describe("getModelScoreThreshold", () => {
+		it("should return score threshold for gemini-embedding-001", () => {
+			const threshold = getModelScoreThreshold("gemini", "gemini-embedding-001")
+			expect(threshold).toBe(0.4)
+		})
+
+		it("should return score threshold for deprecated text-embedding-004", () => {
+			const threshold = getModelScoreThreshold("gemini", "text-embedding-004")
+			expect(threshold).toBe(0.4)
+		})
+
+		it("should return undefined for unknown model", () => {
+			const threshold = getModelScoreThreshold("gemini", "unknown-model")
+			expect(threshold).toBeUndefined()
+		})
+	})
+
+	describe("getDefaultModelId", () => {
+		it("should return gemini-embedding-001 for gemini provider", () => {
+			const defaultModel = getDefaultModelId("gemini")
+			expect(defaultModel).toBe("gemini-embedding-001")
+		})
+
+		it("should return text-embedding-3-small for openai provider", () => {
+			const defaultModel = getDefaultModelId("openai")
+			expect(defaultModel).toBe("text-embedding-3-small")
+		})
+
+		it("should return codestral-embed-2505 for mistral provider", () => {
+			const defaultModel = getDefaultModelId("mistral")
+			expect(defaultModel).toBe("codestral-embed-2505")
+		})
+	})
+})
