fix: show indentation mode in approval UI even when anchor_line is omitted

hannesrudolph · hannesrudolph · commit 0159f2939138 · 2026-01-29T14:08:53.000-07:00
- getLineSnippet() now always displays 'indentation mode at line X' when mode is indentation
- getStartLine() now always returns the effective anchor line for indentation mode
- Both methods use fallback chain: anchor_line ?? offset ?? 1

Addresses review feedback about approval UI not reflecting defaulted anchor_line
diff --git a/src/core/tools/ReadFileTool.ts b/src/core/tools/ReadFileTool.ts
@@ -525,8 +525,9 @@ export class ReadFileTool extends BaseTool<"read_file"> {
 	 * Get the starting line number for navigation purposes.
 	 */
 	private getStartLine(entry: InternalFileEntry): number | undefined {
-		if (entry.mode === "indentation" && entry.anchor_line !== undefined) {
-			return entry.anchor_line
+		if (entry.mode === "indentation") {
+			// For indentation mode, always return the effective anchor line
+			return entry.anchor_line ?? entry.offset ?? 1
 		}
 		const offset = entry.offset ?? 1
 		return offset > 1 ? offset : undefined
@@ -536,8 +537,10 @@ export class ReadFileTool extends BaseTool<"read_file"> {
 	 * Generate a human-readable line snippet for approval messages.
 	 */
 	private getLineSnippet(entry: InternalFileEntry): string {
-		if (entry.mode === "indentation" && entry.anchor_line !== undefined) {
-			return `indentation mode at line ${entry.anchor_line}`
+		if (entry.mode === "indentation") {
+			// Always show indentation mode with the effective anchor line
+			const effectiveAnchor = entry.anchor_line ?? entry.offset ?? 1
+			return `indentation mode at line ${effectiveAnchor}`
 		}
 
 		const limit = entry.limit ?? DEFAULT_LINE_LIMIT
