Enable DM_EXIT spotbugs rule for the full code base

eolivelli · eolivelli · commit 0e5ee07c54bc · 2019-11-15T22:47:52.000+01:00
diff --git a/excludeFindBugsFilter.xml b/excludeFindBugsFilter.xml
@@ -7,8 +7,5 @@
     <!-- this problem is to be addressed in ZOOKEEPER-3227 -->
     <Bug pattern="DM_DEFAULT_ENCODING"/>
 
-    <!-- not really a problem -->
-    <Bug pattern="DM_EXIT"/>
-
 </FindBugsFilter>
 
diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/util/ServiceUtils.java b/zookeeper-server/src/main/java/org/apache/zookeeper/util/ServiceUtils.java
@@ -17,6 +17,7 @@
  */
 package org.apache.zookeeper.util;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.util.Objects;
 import java.util.function.Consumer;
 import org.apache.zookeeper.ZooKeeperMain;
@@ -37,6 +38,7 @@ private ServiceUtils() {
     /**
      * Default strategy for shutting down the JVM.
      */
+    @SuppressFBWarnings("DM_EXIT")
     public static final Consumer<Integer> SYSTEM_EXIT = (code) -> {
         LOG.error("Exiting JVM with code {}", code);
         System.exit(code);
