Repository navigation
Commit ae51b1d
committed
fs: normalize dot segments in rm and rmSync
When paths containing relative components (such as '.' or '..') are
passed to fs.rm(), fs.rmSync(), or fs.promises.rm(), the different
underlying implementations (native binding.rmSync vs JS rimraf)
can produce divergent results or silent deletion failures because
paths were used as-is without canonicalization.
Add normalizePathForRm to resolve dot-segment components for both
string and Buffer inputs using byte-safe latin1 preservation before
reaching the underlying deletion routines.
Fixes: nodejs#61958
Signed-off-by: Rohith Pariki <[email protected]>1 parent 7fab656 commit ae51b1d
3 files changed
Lines changed: 127 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1537 | 1537 | | |
1538 | 1538 | | |
1539 | 1539 | | |
| 1540 | + | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
| 1545 | + | |
| 1546 | + | |
| 1547 | + | |
| 1548 | + | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
1540 | 1563 | | |
1541 | 1564 | | |
1542 | 1565 | | |
| |||
1560 | 1583 | | |
1561 | 1584 | | |
1562 | 1585 | | |
| 1586 | + | |
1563 | 1587 | | |
1564 | 1588 | | |
1565 | 1589 | | |
| |||
1588 | 1612 | | |
1589 | 1613 | | |
1590 | 1614 | | |
| 1615 | + | |
| 1616 | + | |
1591 | 1617 | | |
1592 | | - | |
| 1618 | + | |
1593 | 1619 | | |
1594 | 1620 | | |
1595 | 1621 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1600 | 1600 | | |
1601 | 1601 | | |
1602 | 1602 | | |
| 1603 | + | |
| 1604 | + | |
| 1605 | + | |
| 1606 | + | |
| 1607 | + | |
| 1608 | + | |
| 1609 | + | |
| 1610 | + | |
| 1611 | + | |
| 1612 | + | |
| 1613 | + | |
| 1614 | + | |
| 1615 | + | |
1603 | 1616 | | |
1604 | 1617 | | |
1605 | 1618 | | |
1606 | 1619 | | |
1607 | 1620 | | |
1608 | 1621 | | |
1609 | 1622 | | |
| 1623 | + | |
1610 | 1624 | | |
1611 | 1625 | | |
1612 | 1626 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
657 | 657 | | |
658 | 658 | | |
659 | 659 | | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
0 commit comments