Skip to content

feat: add notification priority#2

Closed
Exordian wants to merge 1 commit intoRocketChat:masterfrom
Catalysts:fcm-add-priority
Closed

feat: add notification priority#2
Exordian wants to merge 1 commit intoRocketChat:masterfrom
Catalysts:fcm-add-priority

Conversation

@Exordian
Copy link
Copy Markdown

add notification priority for FCM

we're currently sending 'data' messages which include no service-level objective to be delivered. RocketChat should send notifications with priority '10'. this change adds the possibility

https://firebase.google.com/docs/cloud-messaging/http-server-ref

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 16, 2019

CLA assistant check
All committers have signed the CLA.

@geekgonecrazy geekgonecrazy changed the title FCM: add notification priority feat: FCM add notification priority Nov 19, 2019
@geekgonecrazy geekgonecrazy changed the title feat: FCM add notification priority feat: add notification priority Nov 19, 2019
@geekgonecrazy
Copy link
Copy Markdown

@Exordian can you check the ci. I think its failing because the commit doesn't follow its style.. which is weird. But I think thats what they were doing upstream

@Exordian
Copy link
Copy Markdown
Author

resolved

@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Nov 25, 2019

FCM docs says the value is a string where valid values are normal and high .. we're now sending 10 on Rocket.Chat .. so I think we need to proper test this and maybe convert the values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants