review

ggazzo · ggazzo · commit 0479240f4e40 · 2025-09-15T15:57:44.000-03:00
diff --git a/packages/federation-sdk/src/services/event-authorization.service.ts b/packages/federation-sdk/src/services/event-authorization.service.ts
@@ -305,11 +305,7 @@ export class EventAuthorizationService {
 			return true;
 		}
 
-		const serverAclContent = aclEvent.getContent() as {
-			allow?: string[];
-			deny?: string[];
-			allow_ip_literals?: boolean;
-		};
+		const serverAclContent = aclEvent.getContent();
 		const {
 			allow = [],
 			deny = [],
diff --git a/packages/federation-sdk/src/services/state.service.ts b/packages/federation-sdk/src/services/state.service.ts
@@ -345,15 +345,15 @@ export class StateService {
 		return new RoomState(state);
 	}
 
-	async getStateEventsByType(
+	async getStateEventsByType<P extends PduType>(
 		roomId: string,
-		type: PduType,
-	): Promise<PersistentEventBase[]> {
+		type: P,
+	): Promise<PersistentEventBase<RoomVersion, P>[]> {
 		const state = await this.getFullRoomState(roomId);
 		const events = [];
 		for (const [, event] of state) {
 			if (event.type === type) {
-				events.push(event);
+				events.push(event as PersistentEventBase<RoomVersion, P>);
 			}
 		}
 		return events;

Original file line number	Diff line number	Diff line change
`@@ -345,15 +345,15 @@ export class StateService {`
`345`	`345`	`return new RoomState(state);`
`346`	`346`	`}`
`347`	`347`
`348`		`- async getStateEventsByType(`
	`348`	`+ async getStateEventsByType<P extends PduType>(`
`349`	`349`	`roomId: string,`
`350`		`- type: PduType,`
`351`		`- ): Promise<PersistentEventBase[]> {`
	`350`	`+ type: P,`
	`351`	`+ ): Promise<PersistentEventBase<RoomVersion, P>[]> {`
`352`	`352`	`const state = await this.getFullRoomState(roomId);`
`353`	`353`	`const events = [];`
`354`	`354`	`for (const [, event] of state) {`
`355`	`355`	`if (event.type === type) {`
`356`		`- events.push(event);`
	`356`	`+ events.push(event as PersistentEventBase<RoomVersion, P>);`
`357`	`357`	`}`
`358`	`358`	`}`
`359`	`359`	`return events;`