Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Support GitLab OAuth#1218

Merged
rafaelks merged 4 commits intodevelopfrom
feat/gitlab_oauth.1161
Feb 22, 2018
Merged

[NEW] Support GitLab OAuth#1218
rafaelks merged 4 commits intodevelopfrom
feat/gitlab_oauth.1161

Conversation

@cardoso
Copy link
Copy Markdown
Member

@cardoso cardoso commented Jan 31, 2018

@RocketChat/ios

There's something wrong with open's gitlab settings, so I'm waiting for it to be fixed.

Closes #1161

@cardoso cardoso added this to the 2.0.0 milestone Jan 31, 2018
@cardoso cardoso requested a review from rafaelks January 31, 2018 00:17
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2018

Codecov Report

Merging #1218 into develop will decrease coverage by 0.07%.
The diff coverage is 6.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1218      +/-   ##
===========================================
- Coverage    30.72%   30.64%   -0.08%     
===========================================
  Files          213      213              
  Lines        10569    10586      +17     
===========================================
- Hits          3247     3244       -3     
- Misses        7322     7342      +20
Impacted Files Coverage Δ
Rocket.Chat/Models/AuthSettings.swift 100% <ø> (ø) ⬆️
...Chat/Models/Mapping/LoginServiceModelMapping.swift 29.06% <0%> (-6.38%) ⬇️
...Chat/Models/Mapping/AuthSettingsModelMapping.swift 17.5% <0%> (-0.23%) ⬇️
...ket.Chat/Controllers/Auth/AuthViewController.swift 0% <0%> (ø) ⬆️
Rocket.Chat/Models/LoginService.swift 38.23% <25%> (-3.04%) ⬇️
...Chat/Controllers/Chat/MainChatViewController.swift 25.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940abe9...a23504a. Read the comment docs.

@rafaelks
Copy link
Copy Markdown
Contributor

rafaelks commented Feb 5, 2018

👍

@rafaelks
Copy link
Copy Markdown
Contributor

rafaelks commented Feb 9, 2018

Back-end is having issues with GitLab authentication: RocketChat/Rocket.Chat#9660

@rafaelks rafaelks modified the milestones: 2.0.0, 2.1.0 Feb 15, 2018
@rafaelks rafaelks changed the title [WIP][NEW] Support GitLab OAuth [NEW] Support GitLab OAuth Feb 22, 2018
@rafaelks
Copy link
Copy Markdown
Contributor

@cardoso Made some changes on scope & removed one unused property. This is working and ready to review. 👍

@cardoso
Copy link
Copy Markdown
Member Author

cardoso commented Feb 22, 2018

It's working for me now @rafaelks 👍 let's merge this

@rafaelks rafaelks merged commit af5f6b5 into develop Feb 22, 2018
@rafaelks rafaelks deleted the feat/gitlab_oauth.1161 branch February 22, 2018 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW] Authentication GitLab

2 participants