Skip to content

[NEW] File upload#882

Merged
diegolmello merged 12 commits intoRocketChat:developfrom
pranavpandey1998official:documentPicker
Jul 18, 2019
Merged

[NEW] File upload#882
diegolmello merged 12 commits intoRocketChat:developfrom
pranavpandey1998official:documentPicker

Conversation

@pranavpandey1998official
Copy link
Copy Markdown
Contributor

@pranavpandey1998official pranavpandey1998official commented May 8, 2019 •
edited
Loading

@RocketChat/ReactNative

added support for file upload

ezgif com-video-to-gif (2)

WhatsApp Image 2019-05-14 at 3 28 11 PM

@pranavpandey1998official pranavpandey1998official changed the title [WIP] file upload [Add] file upload May 9, 2019
@djorkaeffalexandre djorkaeffalexandre self-requested a review May 9, 2019 12:13
djorkaeffalexandre
djorkaeffalexandre suggested changes May 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pranavpandey1998official, You need to set that capabilities to this works on iOS devices: https://github.com/Elyx0/react-native-document-picker#reminder

IlarionHalushka
IlarionHalushka suggested changes May 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@IlarionHalushka IlarionHalushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to run on IOS: null is not an object DocumentPicker.show so created PR to your branch with fix: pranavpandey1998official#1

IlarionHalushka
IlarionHalushka suggested changes May 9, 2019
View reviewed changes
IlarionHalushka
IlarionHalushka suggested changes May 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@IlarionHalushka IlarionHalushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't test pdf extension, but file formats like txt or js fail to upload :(
If you are targeting only pdf then there should be some validation and a hint that says only pdf can be uploaded
image
image

@diegolmello diegolmello changed the title [Add] file upload [NEW] File upload May 16, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 22, 2019

Codecov Report

Merging #882 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #882   +/-   ##
=======================================
  Coverage     82.4%   82.4%           
=======================================
  Files           56      56           
  Lines         1023    1023           
  Branches       187     187           
=======================================
  Hits           843     843           
  Misses         136     136           
  Partials        44      44
Impacted Files Coverage Δ
app/i18n/locales/en.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3cb4ed...eba9ed3. Read the comment docs.

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

djorkaeffalexandre commented May 24, 2019

When I try to upload a file happens this error:

djorkaeffalexandre
djorkaeffalexandre suggested changes May 24, 2019
View reviewed changes
@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

djorkaeffalexandre commented May 29, 2019 •
edited
Loading

Hi @pranavpandey1998official , I runned again your pr but have same error of my last comment, I searched about that and found this issue:
react-native-documents/document-picker#170

This can help you with migration:
https://github.com/Elyx0/react-native-document-picker/wiki/V2-to-V3-migration

@diegolmello diegolmello mentioned this pull request May 31, 2019
Closed
@diegolmello diegolmello mentioned this pull request Jun 19, 2019
Closed
diegolmello
diegolmello requested changes Jun 27, 2019
View reviewed changes
@ccfiel
Copy link
Copy Markdown

ccfiel commented Jul 8, 2019

When this be merge?

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

djorkaeffalexandre commented Jul 10, 2019 •
edited
Loading

@pranavpandey1998official I merged develop and add pt-BR translations in this pr:
pranavpandey1998official#6

diegolmello
diegolmello requested changes Jul 16, 2019
View reviewed changes
@diegolmello diegolmello mentioned this pull request Jul 17, 2019
Closed
2 tasks
diegolmello
diegolmello approved these changes Jul 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'll release a beta without merging for now.

@diegolmello
Merge branch 'develop' into documentPicker
a16c383 
# Conflicts:
#	app/containers/MessageBox/UploadModal.js
#	app/containers/MessageBox/index.js
@diegolmello diegolmello merged commit b4a062e into RocketChat:develop Jul 18, 2019
diegolmello added a commit that referenced this pull request Jul 29, 2019
@diegolmello