Skip to content

chore: remove commit hash reference from @rocket.chat/mobile-crypto dependency#7063

Merged
Rohit3523 merged 2 commits intodevelopfrom
remove-commit-from-package
Mar 24, 2026
Merged

chore: remove commit hash reference from @rocket.chat/mobile-crypto dependency#7063
Rohit3523 merged 2 commits intodevelopfrom
remove-commit-from-package

Conversation

@Rohit3523
Copy link
Copy Markdown
Contributor

@Rohit3523 Rohit3523 commented Mar 24, 2026 •
edited by coderabbitai bot
Loading

Proposed changes

In #7054, we added the dependency using a specific commit hash. This was done to point to a particular PR commit instead of the main branch. This PR removes the commit id and point it to main branch

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Switched the mobile cryptography package dependency from a pinned commit reference to the unpinned repository spec, allowing more flexible version resolution and smoother future updates. This change affects how the package source is resolved and locked during install, with no public API or exported entities modified.

@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build March 24, 2026 12:50 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build March 24, 2026 12:50 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build March 24, 2026 12:50 — with GitHub Actions Error
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 69759589-ea50-41b7-83d9-fdaa0c2f5edd

📥 Commits

Reviewing files that changed from the base of the PR and between 192d92b and 779e4d2.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: E2E Build iOS / ios-build
  • GitHub Check: E2E Build Android / android-build
  • GitHub Check: ESLint and Test / run-eslint-and-test
  • GitHub Check: format

Walkthrough

Updated the @rocket.chat/mobile-crypto dependency spec in package.json from a pinned commit hash to an unpinned repository reference, changing how the package revision is resolved at install time.

Changes

Cohort / File(s) Summary
Dependency Configuration
package.json		 Replaced @rocket.chat/mobile-crypto yarn spec from pinned commit (RocketChat/rocket.chat-mobile-crypto#513c4674346f1f89bad05b679081da20122b735f) with unpinned repository reference (RocketChat/rocket.chat-mobile-crypto).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing a commit hash reference from the @rocket.chat/mobile-crypto dependency version specification in package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 51: Update the dependency entry for "@rocket.chat/mobile-crypto" in
package.json to pin it to the immutable commit used in the lockfile by changing
"RocketChat/rocket.chat-mobile-crypto" to
"RocketChat/rocket.chat-mobile-crypto#57deaffbcda0453c34987efb81d722da7e7a4f9e"
so the package reference is explicit and consistent with other RocketChat fork
pins.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8ce09646-e4dd-4cfd-ac3d-98a67ec75e7c

📥 Commits

Reviewing files that changed from the base of the PR and between fef83b0 and 192d92b.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json
📜 Review details
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:06.688Z
Learning: The RocketChat/Rocket.Chat.ReactNative repository uses a fork of react-native-image-crop-picker (RocketChat/react-native-image-crop-picker) with custom Android edge-to-edge fixes, not the upstream ivpusic/react-native-image-crop-picker package. Dependencies should reference commit pins from the RocketChat fork.
📚 Learning: 2026-02-05T13:55:00.974Z 
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:00.974Z
Learning: In this repository, the dependency on react-native-image-crop-picker should reference the RocketChat fork (RocketChat/react-native-image-crop-picker) with explicit commit pins, not the upstream ivpusic/react-native-image-crop-picker. Update package.json dependencies (and any lockfile) to point to the fork URL and a specific commit, ensuring edge-to-edge Android fixes are included. This pattern should apply to all package.json files in the repo that declare this dependency.

Applied to files:

  • package.json

diegolmello
diegolmello requested changes Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you need to update pods

@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing March 24, 2026 13:24 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build March 24, 2026 13:27 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build March 24, 2026 13:27 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build March 24, 2026 13:27 — with GitHub Actions Error
@Rohit3523 Rohit3523 requested a deployment to experimental_ios_build March 24, 2026 15:09 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to experimental_android_build March 24, 2026 15:09 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to official_android_build March 24, 2026 15:09 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to official_ios_build March 24, 2026 15:09 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a review from diegolmello March 24, 2026 16:01
@Rohit3523 Rohit3523 merged commit 953aef7 into develop Mar 24, 2026
60 of 87 checks passed
@Rohit3523 Rohit3523 deleted the remove-commit-from-package branch March 24, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@diegolmello diegolmello diegolmello approved these changes

Assignees

No one assigned

Labels

type: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rohit3523 @diegolmello