regression: Touchables not working on old messages in some devices by diegolmello · Pull Request #7039 · RocketChat/Rocket.Chat.ReactNative

diegolmello · 2026-03-05T13:56:09Z

Proposed changes

Issue(s)

Regression introduced on #6934
https://rocketchat.atlassian.net/browse/CORE-1906
https://rocketchat.atlassian.net/browse/SUP-1001
Closes #7026

How to test or reproduce

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

Refactor
- Simplified the inverted scroll component implementation and public interface, reducing internal complexity while preserving existing scrolling behavior and user experience. The component now exposes a standard scroll view signature, improving maintainability without changing visible functionality.

coderabbitai · 2026-03-05T13:56:39Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9cebb4de-1bcf-475b-9060-333cb2b4a39f

📥 Commits

Reviewing files that changed from the base of the PR and between 66d94e6 and 0366fcb.

📒 Files selected for processing (1)

app/views/RoomView/List/components/InvertedScrollView.tsx

Walkthrough

Replaced a custom hybrid InvertedScrollView implementation with a simplified wrapper that renders a standard ScrollView whose single child is a native InvertedScrollContentView. Removed custom ref type and internal methods; public API now mirrors a plain ScrollView forwardRef signature.

Changes

Cohort / File(s)	Summary
InvertedScrollView refactor `app/views/RoomView/List/components/InvertedScrollView.tsx`	Removed complex multi-API Android/JS hybrid implementation, custom refs and methods (`scrollTo`, `scrollToEnd`, `flashScrollIndicators`), and extra layout/style logic. Introduced `NativeInvertedScrollContentView = requireNativeComponent<ViewProps>('InvertedScrollContentView')` and simplified export to `forwardRef<ScrollView, ScrollViewProps>` with children wrapped by the native content view. Removed `InvertedScrollViewRef`, `NativeInvertedScrollView`, and related types.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'regression: Touchables not working on old messages in some devices' does not match the actual changes, which focus on simplifying the InvertedScrollView component implementation.	Update the title to accurately reflect the main change, such as 'refactor: Simplify InvertedScrollView component implementation' or 'fix: ScrollView wrapper for InvertedScrollView'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

app/views/RoomView/List/components/InvertedScrollView.tsx (1)
4-4: The native component InvertedScrollContentView is Android-only (confirmed by native module registration in InvertedScrollContentViewManager.java). On iOS, requireNativeComponent will throw a runtime error. However, this component is only used in one location (List.tsx:47), where it already has a platform guard (isIOS ? undefined : props => <InvertedScrollView {...props} />), so there is no active risk.

If you want additional defensive programming, consider adding a platform guard at the component level:
import { Platform } from 'react-native';

if (Platform.OS === 'ios') {
  throw new Error('InvertedScrollView is only supported on Android');
}
This would catch any accidental imports in the future, though the current guard at the usage site is sufficient.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@app/views/RoomView/List/components/InvertedScrollView.tsx` at line 4, The
module currently calls requireNativeComponent('InvertedScrollContentView') via
NativeInvertedScrollContentView which is Android-only and will throw on iOS if
imported; add a platform guard at the top of InvertedScrollView (use
Platform.OS) to throw a clear Error (e.g., "InvertedScrollView is only supported
on Android") or export a no-op on iOS so accidental imports fail fast; ensure
you reference NativeInvertedScrollContentView and any exported component names
(e.g., InvertedScrollView) when applying the guard so the requireNativeComponent
is never executed on iOS.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/views/RoomView/List/components/InvertedScrollView.tsx`:
- Line 4: The module currently calls
requireNativeComponent('InvertedScrollContentView') via
NativeInvertedScrollContentView which is Android-only and will throw on iOS if
imported; add a platform guard at the top of InvertedScrollView (use
Platform.OS) to throw a clear Error (e.g., "InvertedScrollView is only supported
on Android") or export a no-op on iOS so accidental imports fail fast; ensure
you reference NativeInvertedScrollContentView and any exported component names
(e.g., InvertedScrollView) when applying the guard so the requireNativeComponent
is never executed on iOS.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6fbc6aab-49c1-4e65-a7be-90b545243eac

📥 Commits

Reviewing files that changed from the base of the PR and between dbba268 and 66d94e6.

📒 Files selected for processing (1)

app/views/RoomView/List/components/InvertedScrollView.tsx

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: ESLint and Test / run-eslint-and-test
GitHub Check: format

🔇 Additional comments (3)

app/views/RoomView/List/components/InvertedScrollView.tsx (3)
1-2: LGTM! Clean imports with proper type-only imports.

The imports are well-structured and use the type keyword for type-only imports, which is a TypeScript best practice that helps with tree-shaking and build optimization.

6-11: Excellent documentation of the component's purpose and constraints.

The JSDoc clearly explains:

Platform limitation (Android-only)

The accessibility problem being solved (TalkBack reading order)

What behavior is preserved (ScrollView JS-side semantics)

This helps prevent misuse and makes the component's intent clear.

12-20: No changes needed. The component is correctly implemented and compatible with FlatList usage.

The review comment identifies a non-existent concern. The listRef prop is explicitly typed as RefObject<FlatList> (definitions.ts line 7), not as a reference to InvertedScrollView. All methods called on listRef in the codebase—scrollToOffset, scrollToIndex, and scrollToEnd—are FlatList methods, which are all available. InvertedScrollView is used internally as the scroll component for FlatList (via renderScrollComponent prop), and FlatList manages this component internally. The ref forwarding in InvertedScrollView correctly forwards the ref to its internal ScrollView, which is the intended behavior.
			> Likely an incorrect or invalid review comment.

github-actions · 2026-03-05T14:44:05Z

Android Build Available

Rocket.Chat Experimental 4.71.0.108339

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQQrCmDZ8BnI6E-CZKaxHM1ApEdHo8sn27xVimSUVF3t3v2Hjkx47AHaTlsux7yVvtIJyQ3DoJvYt-MJkBL

OtavioStasiak

Looks good to me!

github-actions · 2026-03-05T16:01:50Z

iOS Build Available

Rocket.Chat Experimental 4.71.0.108340

diegolmello temporarily deployed to approve_e2e_testing March 5, 2026 13:56 — with GitHub Actions Inactive

diegolmello changed the title ~~fix: ScrollView wrapper~~ regression: Touchables not working on old messages in some devices Mar 5, 2026

coderabbitai bot added the type: chore label Mar 5, 2026

diegolmello temporarily deployed to experimental_ios_build March 5, 2026 14:00 — with GitHub Actions Inactive

diegolmello had a problem deploying to official_ios_build March 5, 2026 14:00 — with GitHub Actions Failure

diegolmello had a problem deploying to official_android_build March 5, 2026 14:00 — with GitHub Actions Failure

diegolmello temporarily deployed to experimental_android_build March 5, 2026 14:00 — with GitHub Actions Inactive

coderabbitai bot reviewed Mar 5, 2026

View reviewed changes

diegolmello had a problem deploying to upload_experimental_android March 5, 2026 14:40 — with GitHub Actions Failure

This was referenced Mar 5, 2026

bug: Regression: Can't interact with older messages #7026

Closed

chore: Merge 4.70.1 into master #7040

Merged

OtavioStasiak approved these changes Mar 5, 2026

View reviewed changes

ScrollView wrapper

0366fcb

diegolmello force-pushed the fix.inverted-list branch from 66d94e6 to 0366fcb Compare March 5, 2026 16:46

diegolmello merged commit b99320a into develop Mar 5, 2026
2 of 3 checks passed

diegolmello deleted the fix.inverted-list branch March 5, 2026 16:46

coderabbitai bot added type: bug and removed type: chore labels Mar 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression: Touchables not working on old messages in some devices#7039

regression: Touchables not working on old messages in some devices#7039
diegolmello merged 1 commit intodevelopfrom
fix.inverted-list

diegolmello commented Mar 5, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 5, 2026 •

edited

Loading

Review failed

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OtavioStasiak left a comment

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

diegolmello commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

OtavioStasiak left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

diegolmello commented Mar 5, 2026 •

edited

Loading

coderabbitai bot commented Mar 5, 2026 •

edited

Loading