Skip to content

[WIP] Add discussions support#696

Merged
diegolmello merged 34 commits intodevelopfrom
add-threads-support
Apr 8, 2019
Merged

[WIP] Add discussions support#696
diegolmello merged 34 commits intodevelopfrom
add-threads-support

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented Mar 11, 2019 •
edited by diegolmello
Loading

Screen Shot 2019-04-03 at 14 10 06

  • Navigate to a discussion
  • Add "Discussions" to group by type option
  • Refactor room saga
  • Join a discussion
  • i18n
  • Create a discussion
  • E2E tests

@sampaiodiego sampaiodiego changed the title Add threads support [WIP] Add threads support Mar 11, 2019
@sampaiodiego
Copy link
Copy Markdown
Member Author

sampaiodiego commented Mar 11, 2019

tested android build and saw that it didn't work.. I'll need to dig further.

@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Mar 11, 2019

missing prid on schema <3

@diegolmello diegolmello changed the title [WIP] Add threads support [WIP] Add discussions support Apr 2, 2019
@diegolmello diegolmello force-pushed the add-threads-support branch from ae6938b to 2e26ed7 Compare April 5, 2019 20:44
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@7a80550). Click here to learn what that means.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #696   +/-   ##
==========================================
  Coverage           ?   86.59%           
==========================================
  Files              ?       40           
  Lines              ?      716           
  Branches           ?      124           
==========================================
  Hits               ?      620           
  Misses             ?       77           
  Partials           ?       19
Impacted Files Coverage Δ
app/presentation/RoomItem.js 100% <ø> (ø)
storybook/stories/index.js 100% <ø> (ø)
app/i18n/locales/en.js 100% <ø> (ø)
app/i18n/locales/pt-BR.js 100% <ø> (ø)
storybook/stories/Message.js 84.21% <ø> (ø)
app/i18n/locales/pt-PT.js 100% <ø> (ø)
app/containers/message/Image.js 81.81% <100%> (ø)
app/containers/message/Markdown.js 86.04% <100%> (ø)
app/containers/message/Video.js 77.41% <100%> (ø)
app/containers/message/Url.js 83.33% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a80550...2e26ed7. Read the comment docs.

@diegolmello diegolmello merged commit 1d9acdb into develop Apr 8, 2019
@diegolmello diegolmello deleted the add-threads-support branch April 8, 2019 12:35
diegolmello added a commit that referenced this pull request May 29, 2019
@diegolmello
Merge 1.13.0 into Master (#936