fix: prevent SVG crash on iOS and enable rendering on Android by Rohit3523 · Pull Request #6949 · RocketChat/Rocket.Chat.ReactNative

Rohit3523 · 2026-01-26T20:10:15Z

Proposed changes

This pull request fixes issues related to SVG image handling in channel messages.

iOS app crashed when a room contained an SVG image, and Android failed to render SVG images altogether. This update ensures consistent and stable behavior across both platforms by preventing the crash on iOS and enabling proper SVG rendering on Android.

Issue(s)

Closes: #6947
https://rocketchat.atlassian.net/browse/CORE-1764
https://rocketchat.atlassian.net/browse/CORE-1812

How to test or reproduce

Send an SVG image using the web application
Open the same channel in the iOS mobile app
Observe the app crash when the room loads

Screenshots

Before	After

SVG image is not crashing iOS App and rendering without any issue

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

Took reference from expo/expo#38323

Summary by CodeRabbit

Bug Fixes
- Downloaded message images are now constrained to a maximum size (reducing oversized images) for more stable and consistent display.
- Image loading for downloaded attachments has improved reliability, reducing layout issues and unexpected large-image rendering.

coderabbitai · 2026-01-26T20:10:22Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

When message image status is 'downloaded', Image.loadAsync is now called with maxHeight and maxWidth set to 1000; the success path still updates image dimensions and existing error handling remains unchanged.

Changes

Cohort / File(s)	Summary
Image loading `app/containers/message/Components/Attachments/Image/Image.tsx`	For `'downloaded'` images, `Image.loadAsync` is invoked with `{ maxHeight: 1000, maxWidth: 1000 }`. No exported signatures changed; success path still updates dimensions and error handling logic is preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hop through bytes and frames anew,
I stretch to thousand, snug and true.
A careful load, the pixels bloom,
No sudden crash, no frantic zoom.
Hooray — the images stay blue ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title claims to 'fix SVG crash on iOS and enable rendering on Android', but the actual code change only constrains image dimensions (maxHeight/maxWidth: 1000) in the Image component, with no SVG-specific handling or Android-specific changes.	Clarify the title to accurately reflect the actual change (constraining image dimensions), or update the code to include actual SVG-specific fixes and Android-specific handling as described in the title.
Linked Issues check	⚠️ Warning	The code change (constraining loaded image dimensions) does not directly address the core objectives: preventing iOS crashes or enabling SVG rendering on Android. The PR lacks SVG-specific error handling and Android-specific implementation.	Implement SVG-specific handling (e.g., skip loading or use alternative rendering) and Android-specific fixes as described in the linked issues `#6947`, CORE-1764, and CORE-1812.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	The code change appears narrowly scoped to constraining image dimensions, which is reasonably related to image handling but doesn't directly implement the stated SVG crash prevention or Android rendering objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Rohit3523 · 2026-01-26T21:10:30Z

@coderabbitai review

coderabbitai · 2026-01-26T21:10:39Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/containers/message/Components/Attachments/Image/Image.tsx (1)
26-38: Add a .catch() handler to prevent unhandled promise rejections.

The maxHeight and maxWidth options are correctly supported in [email protected] and are the recommended approach for preventing memory exhaustion from large SVGs on iOS. However, the promise chain lacks a .catch() handler, which could result in unhandled promise rejections if image loading fails:
Suggested improvement
 	useEffect(() => {
 		if (status === 'downloaded') {
 			Image.loadAsync(uri, {
 				onError: e => {
 					log(e);
 				},
 				maxHeight: 1000,
 				maxWidth: 1000
-			}).then(image => {
+			})
+			.then(image => {
 				setImageDimensions({ width: image.width, height: image.height });
-			});
+			})
+			.catch(e => {
+				log(e);
+			});
 		}
 	}, [uri, status]);

app/containers/message/Components/Attachments/Image/Image.tsx

OtavioStasiak

Looks good to me!
Run e2e tests and you can merge it :)

Pass max height and width in load async

f9af09c

Rohit3523 had a problem deploying to approve_e2e_testing January 26, 2026 20:10 — with GitHub Actions Error

Rohit3523 changed the title ~~Pass max height and width in load async~~ fix: svg image cause app crash Jan 26, 2026

Rohit3523 had a problem deploying to official_android_build January 26, 2026 20:13 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_android_build January 26, 2026 20:13 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_ios_build January 26, 2026 20:13 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build January 26, 2026 20:13 — with GitHub Actions Error

Rohit3523 changed the title ~~fix: svg image cause app crash~~ fix(iOS): app crashes because of an SVG image Jan 26, 2026

coderabbitai bot reviewed Jan 26, 2026

View reviewed changes

Merge branch 'develop' into svg-crash-fix

8453805

OtavioStasiak had a problem deploying to approve_e2e_testing February 5, 2026 17:01 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_ios_build February 5, 2026 17:03 — with GitHub Actions Error

OtavioStasiak had a problem deploying to official_android_build February 5, 2026 17:03 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_android_build February 5, 2026 17:03 — with GitHub Actions Error

OtavioStasiak had a problem deploying to experimental_ios_build February 5, 2026 17:03 — with GitHub Actions Error

Rohit3523 marked this pull request as ready for review February 9, 2026 12:43

Merge branch 'develop' into svg-crash-fix

45404ba

Rohit3523 marked this pull request as draft February 9, 2026 12:43

Rohit3523 had a problem deploying to approve_e2e_testing February 9, 2026 12:43 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build February 9, 2026 12:45 — with GitHub Actions Error

Rohit3523 requested a deployment to experimental_android_build February 9, 2026 12:45 — with GitHub Actions Waiting

Rohit3523 had a problem deploying to official_android_build February 9, 2026 12:45 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_ios_build February 9, 2026 12:45 — with GitHub Actions Error

Rohit3523 changed the title ~~fix(iOS): app crashes because of an SVG image~~ fix: prevent SVG crash on iOS and enable rendering on Android Feb 10, 2026

reduce max image dimensions

d7b87a4

Rohit3523 had a problem deploying to approve_e2e_testing February 10, 2026 13:22 — with GitHub Actions Error

Merge branch 'develop' into svg-crash-fix

edbc092

diegolmello reviewed Feb 11, 2026

View reviewed changes

app/containers/message/Components/Attachments/Image/Image.tsx Outdated Show resolved Hide resolved

remove error logging from image dimension loading

a2da9d1

Rohit3523 had a problem deploying to approve_e2e_testing February 11, 2026 17:38 — with GitHub Actions Error

Merge branch 'develop' into svg-crash-fix

6184d5b

Rohit3523 had a problem deploying to approve_e2e_testing February 11, 2026 17:38 — with GitHub Actions Error

prettier

480b31c

Rohit3523 temporarily deployed to approve_e2e_testing February 11, 2026 17:41 — with GitHub Actions Inactive

Rohit3523 had a problem deploying to experimental_ios_build February 11, 2026 17:45 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_android_build February 11, 2026 17:45 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build February 11, 2026 17:45 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_android_build February 11, 2026 17:45 — with GitHub Actions Error

Rohit3523 requested a review from OtavioStasiak February 11, 2026 18:13

OtavioStasiak approved these changes Feb 11, 2026

View reviewed changes

Rohit3523 had a problem deploying to official_android_build February 12, 2026 10:56 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build February 12, 2026 10:56 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_android_build February 12, 2026 10:56 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_ios_build February 12, 2026 10:56 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_android_build February 12, 2026 20:43 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_android_build February 12, 2026 20:43 — with GitHub Actions Error

Rohit3523 had a problem deploying to official_ios_build February 12, 2026 20:43 — with GitHub Actions Error

Rohit3523 had a problem deploying to experimental_ios_build February 12, 2026 20:43 — with GitHub Actions Error

Merge branch 'develop' into svg-crash-fix

130e2f9

Rohit3523 had a problem deploying to approve_e2e_testing February 12, 2026 21:48 — with GitHub Actions Failure

Rohit3523 had a problem deploying to experimental_android_build February 12, 2026 21:51 — with GitHub Actions Failure

Rohit3523 had a problem deploying to official_android_build February 12, 2026 21:51 — with GitHub Actions Failure

Rohit3523 had a problem deploying to experimental_ios_build February 12, 2026 21:51 — with GitHub Actions Failure

Rohit3523 had a problem deploying to official_ios_build February 12, 2026 21:51 — with GitHub Actions Failure

Rohit3523 merged commit 757ea73 into develop Feb 12, 2026
5 of 10 checks passed

Rohit3523 deleted the svg-crash-fix branch February 12, 2026 21:51

Rohit3523 mentioned this pull request Feb 12, 2026

Fix SVG attachment sizing and preserve provided dimensions #6851

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: prevent SVG crash on iOS and enable rendering on Android#6949

fix: prevent SVG crash on iOS and enable rendering on Android#6949
Rohit3523 merged 15 commits intodevelopfrom
svg-crash-fix

Rohit3523 commented Jan 26, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 26, 2026 •

edited

Loading

Reviews paused

Uh oh!

Rohit3523 commented Jan 26, 2026

Uh oh!

coderabbitai bot commented Jan 26, 2026

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

OtavioStasiak left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Rohit3523 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Rohit3523 commented Jan 26, 2026

Uh oh!

coderabbitai bot commented Jan 26, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OtavioStasiak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rohit3523 commented Jan 26, 2026 •

edited

Loading

coderabbitai bot commented Jan 26, 2026 •

edited

Loading