Skip to content

fix(Android): prevent image edit action buttons from overlapping system bars#6930

Merged
Rohit3523 merged 8 commits intodevelopfrom
image-crop-android-fix
Feb 10, 2026
Merged

fix(Android): prevent image edit action buttons from overlapping system bars#6930
Rohit3523 merged 8 commits intodevelopfrom
image-crop-android-fix

Conversation

@Rohit3523
Copy link
Copy Markdown
Contributor

@Rohit3523 Rohit3523 commented Jan 19, 2026 •
edited by coderabbitai bot
Loading

Proposed changes

Depends on: RocketChat/react-native-image-crop-picker#8

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1733
Closes: #6925

How to test or reproduce

Screenshots

Before After
image image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Checklist

Summary by CodeRabbit

  • Chores
    • Updated project dependencies for stability and compatibility improvements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 19, 2026 •
edited
Loading

Walkthrough

The react-native-image-crop-picker dependency was updated to a newer commit version. This update targets a bug affecting Android devices where image editing dialog buttons were inaccessible or overlapped by system interface elements.

Changes

Cohort / File(s) Summary
Dependency Update
package.json		 Updated react-native-image-crop-picker commit hash to resolve button accessibility and positioning issues in the image cropping dialog on Android.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A button trapped behind the bar so high,
Now hops back into reach—oh my, oh my!
The crop dialog danced with system's space,
This fix brings controls back into place! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly addresses the main objective of preventing image edit action buttons from overlapping Android system bars, which matches the primary change in the dependency update.
Linked Issues check ✅ Passed The dependency update to react-native-image-crop-picker addresses the core requirement from both linked issues [#6925, CORE-1733] to prevent action buttons from overlapping system bars on Android.
Out of Scope Changes check ✅ Passed The pull request contains only a single, focused dependency update to address the system bar overlap issue; all changes are directly aligned with the linked issue objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch image-crop-android-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 had a problem deploying to official_android_build January 19, 2026 21:32 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build January 19, 2026 21:32 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build January 19, 2026 21:32 — with GitHub Actions Error
@Rohit3523 Rohit3523 changed the title fix (Android): image crop buttons are hiding behind status and navigation bar fix(Android): prevent image edit action buttons from overlapping system bars Jan 30, 2026
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 2, 2026 18:47 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build February 2, 2026 18:47 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 2, 2026 18:47 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 4, 2026 18:16 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build February 4, 2026 18:16 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 4, 2026 18:16 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build February 4, 2026 18:29 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 4, 2026 18:29 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build February 4, 2026 18:29 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android February 4, 2026 19:21 — with GitHub Actions Error
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

Android Build Available

Rocket.Chat Experimental 4.70.0.108213

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRWY5twJ7eSX-fVu1eIW94w_t52vTTikoLfIXpub-uEQgqeM0wWGaqjUH0yuGIKhEkexv4FYTSvExbqDGWy

@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing February 5, 2026 13:16 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 temporarily deployed to experimental_ios_build February 5, 2026 13:20 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 5, 2026 13:20 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to experimental_android_build February 5, 2026 13:20 — with GitHub Actions Inactive
coderabbitai[bot]
coderabbitai bot reviewed Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents 
In `@package.json`:
- Line 101: Replace the commit-pinned dependency for
"react-native-image-crop-picker" with the released semver version to get the
Android safe-area fix: change the value for the "react-native-image-crop-picker"
entry from the GitHub commit reference
("RocketChat/react-native-image-crop-picker#f028aac...") to a semver range
string "^0.51.1" in package.json and run your package manager install to update
lockfiles.

OtavioStasiak
OtavioStasiak approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rohit3523 Rohit3523 had a problem deploying to upload_experimental_android February 5, 2026 20:34 — with GitHub Actions Error
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

Android Build Available

Rocket.Chat Experimental 4.70.0.108225

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNQe3J3ejdIJAv_ncoZbLFpUSa2YgHJod4F106zb1vfun8K_a0Q4M3g08o_vlbDWZ0E26irJilyxeSwdzqKX

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

iOS Build Available

Rocket.Chat Experimental 4.70.0.108226

@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 9, 2026 16:11 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build February 9, 2026 16:11 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 9, 2026 16:11 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 10, 2026 12:20 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 10, 2026 12:20 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build February 10, 2026 12:20 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build February 10, 2026 12:41 — with GitHub Actions Failure
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build February 10, 2026 12:41 — with GitHub Actions Failure
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build February 10, 2026 12:41 — with GitHub Actions Failure
@Rohit3523 Rohit3523 merged commit 294fbb2 into develop Feb 10, 2026
5 of 10 checks passed
@Rohit3523 Rohit3523 deleted the image-crop-android-fix branch February 10, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@OtavioStasiak OtavioStasiak OtavioStasiak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Unable to tap top bar controls/buttons on Android

2 participants

@Rohit3523 @OtavioStasiak