Skip to content

test: fix e2ee nav tests#6816

Merged
diegolmello merged 1 commit intodevelopfrom
tests.fix-e2ee-nav
Dec 3, 2025
Merged

test: fix e2ee nav tests#6816
diegolmello merged 1 commit intodevelopfrom
tests.fix-e2ee-nav

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Nov 27, 2025 •
edited by coderabbitai bot
Loading

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-1540

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Tests
    • Simplified the end-to-end encryption security flow by removing an extra post-navigation verification step.
    • Updated the key-reset test flow to target the appropriate reset action, improving test reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

@diegolmello diegolmello temporarily deployed to approve_e2e_testing November 27, 2025 13:18 — with GitHub Actions Inactive
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Nov 27, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Removed a final visibility assertion in the E2EE security navigation test and updated two selector targets from e2e-encryption-security-view-reset-password-button to e2e-encryption-security-view-reset-key in the reset-key test steps.

Changes

Cohort / File(s) Change Summary
Navigate to E2EE security test
/.maestro/tests/e2ee/utils/navigate-to-e2ee-security.yaml		 Removed the final assertion that checked visibility of e2e-encryption-security-view-reset-password-button after reaching the E2EE security view.
Reset E2EE key test
/.maestro/tests/e2ee/utils/reset-e2ee-key.yaml		 Replaced selector references: e2e-encryption-security-view-reset-password-button → e2e-encryption-security-view-reset-key in extendedWaitUntil (visible) and tapOn actions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review YAML steps for correct selector replacements and ensure no remaining references to the old selector.
  • Verify removal of the assertion doesn't hide an intended test validation (check surrounding navigation/timeouts).

Suggested reviewers

  • OtavioStasiak

Poem

🐇🔑 I hopped along the test's neat track,
Swapped a button for a key and stepped back.
No final check, the flow now light,
Reset the key beneath the moonlight.
Tests hum softly through the night.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'test: fix e2ee nav tests' is vague and generic, using non-descriptive terms that don't convey what specific issue is being fixed. Provide a more specific title that describes the actual fix, such as 'test: fix e2ee security button selectors in navigation' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0ea6cde and 1c529a6.

📒 Files selected for processing (2)
  • .maestro/tests/e2ee/utils/navigate-to-e2ee-security.yaml (0 hunks)
  • .maestro/tests/e2ee/utils/reset-e2ee-key.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello had a problem deploying to experimental_android_build November 27, 2025 13:22 — with GitHub Actions Error
@diegolmello diegolmello merged commit a7c03bc into develop Dec 3, 2025
4 of 6 checks passed
@diegolmello diegolmello deleted the tests.fix-e2ee-nav branch December 3, 2025 17:37
@diegolmello diegolmello had a problem deploying to official_android_build December 3, 2025 17:40 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to experimental_android_build December 3, 2025 17:40 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to experimental_ios_build December 3, 2025 17:40 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@diegolmello