Skip to content

chore: remove detox#6704

Merged
diegolmello merged 7 commits intodevelopfrom
remove-detox-e2e
Nov 5, 2025
Merged

chore: remove detox#6704
diegolmello merged 7 commits intodevelopfrom
remove-detox-e2e

Conversation

@Rohit3523
Copy link
Copy Markdown
Contributor

@Rohit3523 Rohit3523 commented Oct 3, 2025 •
edited by coderabbitai bot
Loading

Proposed changes

Since we have migrated to Maestro for E2E testing, this PR removes Detox, its related tests and Detox native code from Android.

Issue(s)

https://rocketchat.atlassian.net/browse/COMM-59

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Tests

    • Removed the entire end-to-end test suite and associated E2E test runner/configuration, disabling Detox-based E2E tests.

  • Documentation

    • Removed E2E testing guidance and the dedicated E2E README.

  • Chores

    • Cleaned build configuration and removed Detox-related build/test scripts and developer dependencies.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 3, 2025 •
edited
Loading

Walkthrough

This PR removes the Detox end-to-end testing stack and all associated assets: Detox config and Jest/TS e2e configs, e2e helpers/data, all Detox test suites, Android Detox integration, related Gradle/Gradle repo references, e2e npm scripts, and the Detox devDependency.

Changes

Cohort / File(s) Summary of changes
Detox config
​.detoxrc.js		 Deleted Detox configuration export.
Documentation
CONTRIBUTING.md, e2e/README.md		 Removed E2E / Detox documentation and references.
Android Gradle & tests
android/app/build.gradle, android/build.gradle, android/app/src/.../DetoxTest.java		 Removed Detox/appcompat dependencies, testInstrumentation entries, Detox Maven repo, and the Android Detox instrumentation test.
E2E configs & tooling
e2e/jest.config.js, e2e/testSequencer.js, e2e/tsconfig.json		 Deleted e2e Jest config, custom test sequencer, and TypeScript config.
E2E helpers & data
Helper modules
e2e/helpers/*, e2e/data.ts, e2e/e2e_account.example.ts, e2e/helpers/random.ts		 Removed all Detox helpers, API/data setup utilities, example account, and random string utility.
E2E test suites — assorted
e2e/tests/assorted/*		 Deleted all assorted Detox test suites (encryption, broadcast, profile, settings, status, change-server, i18n, display prefs, accessibility, preferences, notifications, avatar, etc.).
E2E test suites — onboarding
e2e/tests/onboarding/*		 Deleted all onboarding Detox tests (onboarding, legal, forgot-password, create-user, login, rooms-list, server-history, change-password-required).
E2E test suites — room
e2e/tests/room/*		 Deleted all room-related Detox test suites (create room, room interactions, actions, discussions, threads, group DM, mark-as-unread, room info, jump-to-message, ignore/report, share, autotranslate).
E2E test suites — team
e2e/tests/team/*		 Deleted all team-related Detox test suites (create team, team behaviors, move/convert).
Package scripts & deps
package.json		 Removed e2e:* npm scripts and Detox devDependency.

Sequence Diagram(s)

No sequence diagrams — the changes remove tests/configs and do not introduce new runtime control flow to visualize.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Potential focus areas:

  • android/app/build.gradle and android/build.gradle for removed repo/dependency entries and any unintended Gradle side-effects.
  • Large deletions under e2e/helpers and e2e/tests (verify there are no remaining references/imports elsewhere).
  • package.json script and devDependency removal (CI or developer tooling that previously relied on these).

Possibly related PRs

Poem

I’m a rabbit with a tiny test kit,
I nudge the trails where Detox once lit.
I stash the scripts and tip my hat,
New maps will come — for now, that’s that.
Hoppity-hop, the code will grow, 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'chore: remove detox' clearly and concisely describes the main change—complete removal of Detox E2E testing framework and related code from the project.
Linked Issues check ✅ Passed The PR successfully removes all Detox-related code, configuration, and tests as required by COMM-59, including the Detox configuration file, test suites, helper utilities, documentation, Android native integration, and npm scripts.
Out of Scope Changes check ✅ Passed All changes are directly related to removing Detox: configuration files, E2E test files, helper modules, build configurations, documentation, and npm scripts. No unrelated modifications are present.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-detox-e2e
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1f5af2a and d321f2c.

📒 Files selected for processing (2)
  • android/app/build.gradle (0 hunks)
  • package.json (0 hunks)
💤 Files with no reviewable changes (2)
  • package.json
  • android/app/build.gradle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Rohit3523 Rohit3523 had a problem deploying to official_android_build October 3, 2025 16:28 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build October 3, 2025 16:28 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build October 3, 2025 16:28 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing October 15, 2025 14:20 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build October 15, 2025 14:25 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to official_android_build October 15, 2025 14:25 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build October 15, 2025 14:25 — with GitHub Actions Error
@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing October 15, 2025 16:00 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build October 15, 2025 16:03 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build October 15, 2025 16:03 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build October 15, 2025 16:03 — with GitHub Actions Error
@Rohit3523 Rohit3523 changed the title Remove detox test chore: remove detox Oct 15, 2025
@Rohit3523 Rohit3523 temporarily deployed to approve_e2e_testing October 15, 2025 17:48 — with GitHub Actions Inactive
@Rohit3523 Rohit3523 had a problem deploying to official_android_build October 15, 2025 17:52 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build October 15, 2025 17:52 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build October 15, 2025 17:52 — with GitHub Actions Error
@Rohit3523 Rohit3523 marked this pull request as ready for review October 15, 2025 19:31
@Rohit3523 Rohit3523 requested a review from diegolmello October 15, 2025 19:31
@Rohit3523 Rohit3523 had a problem deploying to official_android_build October 22, 2025 17:50 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_ios_build October 22, 2025 17:50 — with GitHub Actions Error
@Rohit3523 Rohit3523 had a problem deploying to experimental_android_build October 22, 2025 17:50 — with GitHub Actions Error
@diegolmello diegolmello temporarily deployed to approve_e2e_testing October 31, 2025 19:00 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_ios_build October 31, 2025 19:04 — with GitHub Actions Inactive
@diegolmello diegolmello temporarily deployed to experimental_android_build October 31, 2025 19:04 — with GitHub Actions Inactive
@diegolmello diegolmello had a problem deploying to upload_experimental_android October 31, 2025 20:21 — with GitHub Actions Error
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2025

iOS Build Available

Rocket.Chat Experimental 4.66.0.107617

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 31, 2025

Android Build Available

Rocket.Chat Experimental 4.66.0.107616

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNRV8OO9B93cq6cxjJRtmM3gHZy0vQwMQ2Za43EErlJ5t8nGxNqO7LDjLALhPHDBeo_WiHJXFWGgosKNqtAo

@diegolmello diegolmello had a problem deploying to experimental_android_build November 5, 2025 13:43 — with GitHub Actions Error
@diegolmello diegolmello merged commit 2d51ccf into develop Nov 5, 2025
5 of 6 checks passed
@diegolmello diegolmello deleted the remove-detox-e2e branch November 5, 2025 20:28
@diegolmello diegolmello had a problem deploying to experimental_android_build November 5, 2025 20:32 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to experimental_ios_build November 5, 2025 20:32 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to official_android_build November 5, 2025 20:32 — with GitHub Actions Failure
This was referenced Nov 6, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 19, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rohit3523 @diegolmello