.github/workflows/e2e-build-ios.yml (1)

82-82: Drop redundant export

RUNNING_E2E_TESTS is already provided via the step env. The extra export can be removed to avoid confusion.

-          export RUNNING_E2E_TESTS=true

app/containers/message/interfaces.ts (1)

114-116: New a11y props on IMessageInner are unused

MessageInner doesn’t forward/use these props. Either wire them to the rendered View or drop them to keep types lean.

-	accessible?: boolean;
-	accessibilityLabel?: string;

If you keep them, pass them to the root View where content is rendered.

babel.config.js (1)

7-9: Ensure Reanimated plugin is last

Per Reanimated docs, the plugin should be the last in the list. Reorder to prevent subtle build issues.

  plugins: [
    ['@babel/plugin-proposal-decorators', { legacy: true }],
-   'react-native-reanimated/plugin',
    '@babel/plugin-transform-named-capturing-groups-regex',
    ['module:react-native-dotenv'],
    ['transform-inline-environment-variables', { include: ['RUNNING_E2E_TESTS'] }]
+   ,'react-native-reanimated/plugin'
  ],

.maestro/helpers/select-media.yaml (1)

1-12: Helper name/content mismatch and redundant pathing

The file selects a room, not media. Consider renaming to select-room.yaml. Also, from helpers/, ../helpers resolves to the same dir—simplify paths.

-    file: '../helpers/search-room.yaml'
+    file: './search-room.yaml'
...
-    file: '../helpers/navigate-to-room.yaml'
+    file: './navigate-to-room.yaml'

app/containers/message/Message.tsx (1)

145-147: Clarify read/unread logic

Treat only explicit false as “read”; undefined/null shouldn’t imply read.

-		const readOrUnreadLabel =
-			!props.unread && props.unread !== null ? i18n.t('Message_was_read') : i18n.t('Message_was_not_read');
+		const readOrUnreadLabel = props.unread === false ? i18n.t('Message_was_read') : i18n.t('Message_was_not_read');

.maestro/room/room.yaml (1)

256-260: Normalize swipe direction casing

Stick to a single convention (e.g., DOWN/UP) to avoid parser ambiguities.

-    direction: down
+    direction: DOWN

-    direction: UP
+    direction: UP

Also applies to: 416-419

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.maestro/tests/room/create-room.yaml (3)

175-180: Alert button selector may be brittle under localization.
Using tapOn: 'OK' can fail on non-English. Prefer an id-based selector or platform-guarded text match. If no id exists, consider a small helper flow that taps the first visible alert button cross‑platform.

---

164-179: “general” channel existence is assumed.
Some workspaces disable/rename “general.” Consider gating this step behind a server capability check or use a temp room you create in this test to assert “already exists.”

---

12-24: Extract Create-Channel flow & centralize timeouts

• Replace duplicated extendedWaitUntil/tapOn sequence (id: rooms-list-view-create-channel) with existing helper: .maestro/tests/teams/utils/create-channel.yaml. Occurrences to update: .maestro/tests/room/create-room.yaml, .maestro/tests/teams/create-team.yaml, .maestro/tests/onboarding/roomslist.yaml, .maestro/tests/assorted/e2e-encryption.yaml, .maestro/tests/assorted/display-perf.yaml, .maestro/tests/assorted/broadcast.yaml.
• Introduce a defaultTimeout env (20–30s) and remove hardcoded 60000 values; retain 60000 only where a longer wait is demonstrably required for stability.

.maestro/tests/room/room.yaml (8)

1-8: Setup/teardown is sane; also clean up created rooms.
onFlowEnd deletes users but not rooms. If available, call a deleteCreatedRooms util to keep the workspace clean.

 onFlowEnd:
   - evalScript: ${output.utils.deleteCreatedUsers()}
+  - evalScript: ${output.utils.deleteCreatedRooms && output.utils.deleteCreatedRooms()}

---

80-103: Avoid relying on “#general”; use the room you just created.
Prevents server-config coupling.

- inputText: '#general'
+ inputText: ${'#'+output.room.name}
- extendedWaitUntil:
-   visible:
-     id: 'autocomplete-item-general'
+ extendedWaitUntil:
+   visible:
+     id: 'autocomplete-item-${output.room.name}'
  - tapOn:
-     id: 'autocomplete-item-general'
+     id: 'autocomplete-item-${output.room.name}'
- extendedWaitUntil:
-   visible:
-     text: '#general '
+ extendedWaitUntil:
+   visible:
+     text: ${'#'+output.room.name+' '}
- extendedWaitUntil:
-   notVisible:
-     id: 'autocomplete-item-general'
+ extendedWaitUntil:
+   notVisible:
+     id: 'autocomplete-item-${output.room.name}'

---

104-175: Emoji ids can differ per platform/theme; guard or fall back to search.
If emoji-grinning/wink ids vary, use the emoji search input consistently instead of raw ids or wrap with platform conditions.

Also applies to: 188-210, 211-240

---

241-264: Inconsistent swipe direction casing; add animation settle before swipe.
Use uniform casing (DOWN/UP) and wait for the sheet to settle for stability.

- swipe:
+ waitForAnimationToEnd
+ swipe:
     from:
       id: action-sheet-handle
-    direction: down
+    direction: DOWN

- swipe:
+ waitForAnimationToEnd
+ swipe:
     from:
       id: action-sheet-handle
     direction: UP

Also applies to: 416-419

---

310-346: Action sheet interactions: add a waitForAnimationToEnd after opening.
Prevents intermittent “element not hittable” errors on iOS.

- extendedWaitUntil:
-   visible:
-     id: action-sheet
-   timeout: 60000
+ extendedWaitUntil:
+   visible:
+     id: action-sheet
+   timeout: 60000
+ waitForAnimationToEnd

Also applies to: 400-435

---

265-285: Username taps: prefer id over text to avoid l10n/clashing occurrences.
If available, target a stable testID (e.g., user-tile-${username}) rather than raw text.

Also applies to: 286-309

---

499-532: Draft flows are thorough; consider collapsing repeated navigate/back steps.
Extract “navigate-to-room, assert composer text” into a helper to speed up and de-duplicate.

Also applies to: 533-637

---

32-79: Autocomplete cleanup: ensure notVisible waits use shorter timeouts.
Use 5–10s for disappearance to reduce run time.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

.maestro/tests/room/room.yaml (6)

80-99: Avoid hardcoding #general; use the created room to reduce env coupling.

Some workspaces don’t have General or it’s restricted.

-- inputText: '#general'
+- inputText: '#${output.room.name}'
 ...
-- extendedWaitUntil:
-    visible:
-      id: 'autocomplete-item-general'
+- extendedWaitUntil:
+    visible:
+      id: 'autocomplete-item-${output.room.name}'
 ...
-- tapOn:
-    id: 'autocomplete-item-general'
+- tapOn:
+    id: 'autocomplete-item-${output.room.name}'
 ...
-- extendedWaitUntil:
-    visible:
-      text: '#general '
+- extendedWaitUntil:
+    visible:
+      text: '#${output.room.name} '
 ...
-- extendedWaitUntil:
-    notVisible:
-      id: 'autocomplete-item-general'
+- extendedWaitUntil:
+    notVisible:
+      id: 'autocomplete-item-${output.room.name}'

---

211-220: Prefer a wait over an immediate assert to reduce flakes.

Switch to an explicit wait before tapping the add‑reaction button.

-# should show reaction picker on add reaction button pressed and have frequently used emoji
-- assertVisible:
-    id: message-add-reaction
+# should show reaction picker on add reaction button pressed and have frequently used emoji
+- extendedWaitUntil:
+    visible:
+      id: message-add-reaction
+    timeout: 60000

---

12-15: Resource cleanup: consider deleting created rooms too.

You delete users on teardown; rooms created by those users may persist depending on server policies.

Option: track created room IDs in utils and delete them in onFlowEnd.

---

104-138: Quote regex strings for YAML safety.

Unquoted patterns like .${…}. can be misparsed by some YAML parsers; quoting improves robustness.

Example:

-      text: .*${output.randomMessage}.*
+      text: '.*${output.randomMessage}.*'

Apply similarly to other regex-like text matchers.

---

499-531: Draft verification: assert composer is cleared after send.

Current check could pass on message bubble; add a negative check on the composer to ensure no residual draft.

 - tapOn:
     id: 'message-composer-send'
 - extendedWaitUntil:
     visible:
       text: '.*draft.*'
     timeout: 60000
+- extendedWaitUntil:
+    notVisible:
+      id: message-composer-input
+      # composer should not contain the draft anymore
+    timeout: 60000

---

139-175: Emoji IDs can diverge across platforms/skins.

If iOS failures persist here, consider falling back to searching by shortcode text first, then tapping the first result, instead of hardcoding emoji-* IDs.

I can extract a helper flow (select-emoji.yaml) that searches and taps by shortcode for cross‑platform stability.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro