app/views/AccessibilityAndAppearanceView/index.tsx (2)

123-133: Critical: Remove duplicate ListPicker section.

Lines 123-133 contain an exact duplicate of the ListPicker section at lines 112-122. Remove this duplicate section.

Apply this diff to remove the duplicate:

-				<List.Section>
-					<List.Separator />
-					<ListPicker
-						onChangeValue={value => {
-							setAlertDisplayType(value);
-						}}
-						title={I18n.t('A11y_appearance_show_alerts_as')}
-						value={alertDisplayType ?? 'TOAST'}
-					/>
-					<List.Separator />
-				</List.Section>

---

92-92: Critical: Remove platform-specific accessibilityRole and use 'switch' on all platforms.

The conditional accessibilityRole={isIOS ? 'switch' : 'none'} breaks TalkBack support on Android by removing all semantic information. React Native Switch components require accessibilityRole='switch' on both iOS and Android for proper assistive technology support.

Apply this diff to fix the accessibility role on all three switches:

-					accessibilityRole={isIOS ? 'switch' : 'none'}
+					accessibilityRole='switch'

Also applies to: 100-100, 108-108

app/views/SelectedUsersView/index.tsx (1)

73-74: Address incomplete dependency array and verify empty-string fallback behavior.

Two issues need attention:

1. Operator choice (lines 73-74): The || operator treats empty string as falsy. If a caller explicitly passes buttonText="" to hide the button label, it will now fall back to 'Next' instead. If this is intentional across all call sites, document it; otherwise use ?? (nullish coalescing) to preserve empty strings.

2. Incomplete dependencies (line 87): The useLayoutEffect references title (line 72), showSkipText (line 68 via handleButtonTitle), and showButton (line 79), but these are missing from the dependency array. If any of these props change at runtime, the header won't update correctly.

Based on past review comments, this issue was previously flagged but remains unaddressed.

Apply this diff to fix the dependency array:

-	}, [navigation, users.length, maxUsers, buttonText, nextAction]);
+	}, [navigation, users.length, maxUsers, buttonText, nextAction, title, showSkipText, showButton]);

For the operator choice, verify with call sites whether empty string is a valid intentional value. If yes, keep ||; if no, use ??:

-	const buttonTextHeader = buttonText || I18n.t('Next');
-	const nextActionHeader = nextAction || (() => {});
+	const buttonTextHeader = buttonText ?? I18n.t('Next');
+	const nextActionHeader = nextAction ?? (() => {});

Also applies to: 87-87

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

.maestro/tests/room/discussion.yaml (1)

81-85: Consider adding a wait for the action sheet to dismiss after channel selection.

After tapping multi-select-item-${output.room.name} (line 82), the action sheet animates closed. The immediate tap on multi-select-discussion-name (line 84) could be flaky if the action sheet overlay is still present. If you observe intermittent failures here, consider adding a wait:

 - tapOn:
     id: 'multi-select-item-${output.room.name}'
+- extendedWaitUntil:
+    notVisible:
+      id: 'action-sheet'
+    timeout: 5000
 - tapOn:
     id: 'multi-select-discussion-name'

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

app/views/AccessibilityAndAppearanceView/index.tsx (1)

122-132: Remove duplicate ListPicker section.

Lines 122–132 are an exact duplicate of the ListPicker section on lines 111–121 (only trivial difference: ?? vs || in the value prop). This duplication will render the picker twice in the UI and was already flagged in a previous review.

Remove the duplicate section entirely:

   </List.Section>
-  <List.Section>
-    <List.Separator />
-    <ListPicker
-      onChangeValue={value => {
-        setAlertDisplayType(value);
-      }}
-      title={I18n.t('A11y_appearance_show_alerts_as')}
-      value={alertDisplayType ?? 'TOAST'}
-    />
-    <List.Separator />
-  </List.Section>
 </List.Container>

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:14.049Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:14.049Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

app/containers/List/ListItem.tsx (1)

138-138: Consider fixing the function name typo for consistency.

The function is named handleAcessibilityLabel (with the old typo) while all the properties it uses have been corrected to Accessibility. Renaming to handleAccessibilityLabel would improve consistency.

🔎 Proposed fix

-	const handleAcessibilityLabel = useMemo(() => {
+	const handleAccessibilityLabel = useMemo(() => {
 		let label = '';
 		if (accessibilityLabel) {
 			return accessibilityLabel;

And update the usage on line 175:

-			accessibilityLabel={handleAcessibilityLabel}
+			accessibilityLabel={handleAccessibilityLabel}

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:22.578Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:22.578Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

app/containers/List/ListItem.tsx (1)

138-138: Consider renaming the internal function for consistency.

While the prop names were corrected to additionalAccessibilityLabel, the internal function handleAcessibilityLabel still uses the old spelling. For consistency, consider renaming it to handleAccessibilityLabel.

🔎 Proposed rename

Line 138:

-		const handleAcessibilityLabel = useMemo(() => {
+		const handleAccessibilityLabel = useMemo(() => {

Line 175:

-			accessibilityLabel={handleAcessibilityLabel}
+			accessibilityLabel={handleAccessibilityLabel}

Also applies to: 175-175

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:22.578Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:22.578Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

.maestro/tests/assorted/join-from-directory.yaml (3)

29-30: Consider reducing the animation timeout.

A 10-second timeout for waitForAnimationToEnd is quite long. If this was added to address test flakiness, consider whether a shorter duration (e.g., 2-3 seconds) would suffice, which would improve test execution time.

---

100-103: Consider adding state-change verification and initial state setup.

The test now relies on the accessibility label format 'Users unselected', which makes it more brittle. Additionally:

1. The test assumes 'Users' starts unselected but doesn't explicitly verify or set the initial filter state.
2. After tapping 'Users unselected' (line 103), there's no verification that the filter actually changed state (e.g., checking for 'Users selected' or verifying the directory content changed).

This could lead to flakiness if:

• The label format changes (e.g., to '☐ Users' or 'Users (unselected)')
• Previous tests or saved state leave 'Users' already selected
• The tap doesn't successfully change the filter

Consider adding verification steps

After line 103, add a step to verify the filter changed:

- extendedWaitUntil:
    visible:
      text: 'Users selected'
    timeout: 5000

Or verify the filter menu closed and directory content reflects the Users filter.

---

148-151: Same concerns as the 'Users unselected' change above.

This has the same brittleness and missing verification issues as the 'Users unselected' change in lines 100-103. After tapping 'Teams unselected' (line 151), consider adding verification that the filter state changed to 'Teams selected' or that the directory content reflects the Teams filter.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:22.578Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

app/views/CreateDiscussionView/index.tsx (1)

49-51: Stale state issue remains unresolved.

The previous review comment about state synchronization is still applicable. The local users state (line 69) is initialized from Redux selectedUsers once at mount but never synchronizes with subsequent Redux updates. If a user navigates away to add more users and returns, the UI will show stale data.

Please refer to the previous review comment for recommended solutions (use Redux state directly or add a useEffect to sync).

Also applies to: 98-100, 116, 181

Also applies to: 53-53, 63-64, 69-69

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:22.578Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.

Learnt from: OtavioStasiak
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6499
File: app/containers/ServerItem/index.tsx:34-36
Timestamp: 2025-12-17T15:56:22.578Z
Learning: In the Rocket.Chat React Native codebase, for radio button components on iOS, include the selection state ("Selected"/"Unselected") in the accessibilityLabel instead of using accessibilityState={{ checked: hasCheck }}, because iOS VoiceOver has known issues with accessibilityRole="radio" + accessibilityState that prevent correct state announcement.