Skip to content

Use Rest API calls#558

Merged
diegolmello merged 34 commits intodevelopfrom
temp-sdk
Dec 5, 2018
Merged

Use Rest API calls#558
diegolmello merged 34 commits intodevelopfrom
temp-sdk

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Dec 4, 2018

@RocketChat/ReactNative

@diegolmello
Login/resume working
3bea865
@diegolmello
settings and permissions
dd4ca53
@diegolmello
custom emojis
c879696
@diegolmello
Merge branch 'develop' into new-sdk
4d4c011 
# Conflicts:
#	app/lib/rocketchat.js
#	app/reducers/app.js
#	app/sagas/login.js
@diegolmello
Api and ddp working
26fc03d
@diegolmello
Room
ec28104
@diegolmello
room actions
453f3b1
@diegolmello
Room members
02f19b5
@diegolmello
Streams
f8ba2cc
@diegolmello
User data saved in asyncstorage refactored
5b49bd9
@diegolmello
Create dm
86300df
@diegolmello
Load messages and join
353e5d2
@diegolmello
React and fav
0a85905
@diegolmello
Login (error and totp)
5c0cca6
@diegolmello
Oauth, share, delete, edit, star, pin
1aa80cd
@diegolmello
Sort prefs
3f3ee54
@diegolmello
Parse settings, custom emojis and roles on server select from local db
266a635
@diegolmello
Forgot password
41a2c3f
@diegolmello
Enable unsecure websocket
daa5084
@diegolmello
Favicon
bf4b04a
@diegolmello
Register
c875f50
@diegolmello
Set username
b64a399
@diegolmello
Remove login.token
eb0d365
@diegolmello
Refactoring
2f0d65f
@diegolmello
Detox
0e73a22
@diegolmello
Downgrade react-native-fast-image
0c2e448
@diegolmello
Refactoring
d9612b0
@diegolmello
Bug fixes
bfbb486
@diegolmello
Use temp SDK
f38723c
@diegolmello
- Refactoring
b7b1f42 
- Change sort prefs default
@diegolmello diegolmello changed the title [WIP] Use Rest API calls Use Rest API calls Dec 5, 2018
@diegolmello diegolmello merged commit a2821af into develop Dec 5, 2018
@diegolmello diegolmello deleted the temp-sdk branch December 5, 2018 20:52
@FaizanZahid
Copy link
Copy Markdown

FaizanZahid commented Dec 6, 2018

i will test and give my findings, good work so far.

@FaizanZahid
Copy link
Copy Markdown

FaizanZahid commented Dec 6, 2018 •
edited
Loading

My feedback:

  1. Overall the app looks a bit slow in doing actions as compared to the native kotlin android app. Like opening images, loading old chats , opening a room for first time. etc Why its not fast like fb messenger, when these both apps r on react native.

  2. Long and fast scroll down on files attachment page still shows a blank white page. Unable to fully scroll to the end of the files attachments. it shows re scrolls mid way on top.

  3. i tested these changes on 1.6.1.5184

  4. Is this the same app for iOS react native too? or the iOS one is more stable? Which i0S version should we deploy for production, the native swift one for iOS or the react native one for iOS.?

  5. It takes a bit long time to retrieve the old messages convo when opening a DM room for first time. but thankfully on new DMs , now the app is not crashing :)

  6. There is a slight lag when i send the message and it get sent, may be i m being too optimistic and its just my network.

Over all good work, the only thing is lag in the overall app usage is bad for UX.

Once my team tests and give more feedback, i will update.

@achilles-kosun achilles-kosun mentioned this pull request Dec 7, 2018
Closed
diegolmello added a commit that referenced this pull request May 29, 2019
@diegolmello
Merge 1.13.0 into Master (#936)
fe46929 
* fix last messages (#239)

* fix last messages

* Room actions (#231)

* Layout


* Empty starred list


* Favorite room

* Pinned messages

* fix last messages

* fix date on pinned messages

* fix package

* [NEW] OAuth (#241)

* Layout

* tmp

* test iscordova

* Webview redirecting

* Open and Close login actions

* Login services saved on redux

* OAuth Github

* Server regex fix

* OAuth modal style

* - Twitter login
- Remove services from redux
- Open login saga fix

* - Facebook login
- Fixed user agent
- Reactions fix
- Message url unique key fix

* Google login

* Email keyboard removed from messagebox

* - Login buttons refactored
- RoomList header

* Layout improvements

* Meteor login redirect_uri changed

* fix

* Random credentialToken state

* [NEW] Room actions: Mentioned messages and Room Members (#242)

* Mentioned messages

* Starred and pinned actions debounce

* Room members

* Open room on member touch

* [WIP] Improves (#245)

*  hotfix for ios

*  hotfix for ios

* Update config.yml

* Workaround for RN 0.54 on iOS (#246)

* Update iOS to RN 0.54 (#248)

* Update iOS to RN 0.54

* [WIP] Audio message functionality (#247)

* [NEW] Add module react-native-audio

* [WIP] Audio message basic UI

* [NEW] Record audio message

* Use cordova repository to get certificates

* Icon 1024

* [NEW] Room actions: block user, snippet messages, room files and leave room (#250)

* - Block user
- Load room members async
- fixed reactive change of room's read only flag

* Snippet messages

* - Room files
- Dismiss Video component on back button press
- Improvements on Image component

* Improvement on Video component

* Leave room

* Missing message types

* lint

* Reactotron working (#249)

* [NEW] Room info and Room info edit (#254)

* - Block user
- Load room members async
- fixed reactive change of room's read only flag

* Snippet messages

* - Room files
- Dismiss Video component on back button press
- Improvements on Image component

* Improvement on Video component

* Leave room

* Missing message types

* lint

* - Room info (read only)
- Missing message types

* Room info scroll

* - Tap on room header opens room info
- Layout tweaks

* - Room info edit
-