Components moved to 'containers' or 'presentation' folders.#40
Merged
Components moved to 'containers' or 'presentation' folders.#40
Conversation
Extracted some components from Message component to have less logic in component.
|
|
Codecov Report
@@ Coverage Diff @@
## develop #40 +/- ##
======================================
Coverage 100% 100%
======================================
Files 6 6
Lines 39 44 +5
Branches 7 9 +2
======================================
+ Hits 39 44 +5
Continue to review full report at Codecov.
|
ggazzo
reviewed
Sep 4, 2017
.vscode/launch.json
Outdated
| @@ -0,0 +1,41 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
remove this file and ignore it on git :)
gilmarsquinelato
commented
Sep 4, 2017
| }; | ||
|
|
||
| const uri = avatar || `${ baseUrl }/avatar/${ text }`; | ||
| const image = (avatar || baseUrl) && ( |
Contributor
Author
There was a problem hiding this comment.
But the text is before the image, just in a variable to reduce code complexity.
ggazzo
approved these changes
Sep 4, 2017
djorkaeffalexandre
pushed a commit
that referenced
this pull request
Aug 9, 2019
Components moved to 'containers' or 'presentation' folders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted some components from Message component to have less logic in component.