[FIX] Black screen during Share#3320
Conversation
| const { | ||
| title_link, image_url, image_type, video_url, video_type | ||
| } = attachment; | ||
| const { title_link, image_url, image_type, video_url, video_type } = attachment; |
There was a problem hiding this comment.
Unrelated, but prettier asked me to change.
It won't hurt :)
diegolmello
force-pushed
the
share-black-screen
branch
from
9996234 to
3b08b43
Compare
|
The issue is that we're calling |
|
@cprice-kgi Merged. Thanks for your contribution :) |
|
Is this the same problem that happens when one tries to share a audio received on whatsapp with someone on rockechat ? After choosing the contact for share, rocketchat gets stuck on a blank window. ( on android , running version 4.20) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3320 +/- ##
========================================
Coverage 71.21% 71.21%
========================================
Files 153 153
Lines 2758 2758
Branches 648 648
========================================
Hits 1964 1964
Misses 760 760
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 participants
Proposed changes
Something about RNSplashScreen.hide is causing an issue here. I wrapped the call in a try/catch.
Issue(s)
#3088
How to test or reproduce
Try to share an image either from within the app or from an another application to the app. After investigation, I have found this issue appears only when the server has the mobile screen lock value enabled. If it is disabled, sharing will work fine. If enabled, the call to RNSplashScreen.hide will cause a black screen to appear, and the user is unable to proceed.
Screenshots
Types of changes
Checklist
Further comments
N/A