Chore: Update Jitsi to 3.6.0 by diegolmello · Pull Request #3292 · RocketChat/Rocket.Chat.ReactNative

diegolmello · 2021-07-22T21:10:29Z

Proposed changes

Updates Jitsi SDK to 3.6.0.
All forks were updated.

Issue(s)

Depends on:
RocketChat/react-native-jitsi-meet#9
RocketChat/jitsi-maven-repository#2
RocketChat/jitsi-meet-ios-sdk-releases#5
RocketChat/jitsi-meet#14

How to test or reproduce

Starting a call

Go to any room actions
Tap Voice call/Video call (we should test both)

Joining from message

Start a call from web
A "Call started by" message should be sent to the room
Join by tapping "Click to join"
Known issue: During development, I found that if you start this process from mobile and try to join on the web, it won't work. We need to test that and check if there's an open issue on the web repo.

Joining from push notification

Start a call from web
A push notification should be sent to your device
Join by tapping the push notification

Test Jitsi features

We need to test Jitsi features making sure everything is working properly (mute, turn off cam, etc)
Some of them might be flaky or not work because of Jitsi itself, but it's good to be aware of

Dark mode

Enable dark mode on your device
Everything should be visible

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

# Conflicts: # ios/Podfile.lock # yarn.lock

diegolmello · 2021-08-13T13:32:49Z

android/build.gradle

        libre_build = !(isPlay.toBoolean())
-        jitsi_url = isPlay ? "https://github.com/RocketChat/jitsi-maven-repository/raw/master/releases" : "https://github.com/RocketChat/jitsi-maven-repository/raw/libre/releases"
-        jitsi_version = isPlay ? "2.10.2" : "2.10.0-libre"
+        jitsi_url = isPlay ? "http://github.com/RocketChat/jitsi-maven-repository/raw/3.7.0/releases" : "https://github.com/jitsi/jitsi-maven-repository/raw/libre/releases"


We're not actively maintaining libre, so I just changed the URL to match, but there's no point to test at this time.

https instead

diegolmello · 2021-08-13T13:34:06Z

app/views/JitsiMeetView.js

+		const { route } = this.props;
+		const { userInfo } = this.state;
+
+		if (isIOS) {


I'm calling Jitsi on iOS the old way and Android using props.
For some reason I didn't understand, Android is not working this way anymore.

diegolmello · 2021-08-13T13:34:44Z

app/views/JitsiMeetView.js

 				onConferenceJoined={this.onConferenceJoined}
-				style={sharedStyles.container}
+				style={StyleSheet.absoluteFill}
+				options={options}


This is what triggers the call on Android from now on.

diegolmello · 2021-08-13T13:35:18Z

ios/Podfile

 abstract_target 'defaults' do
  # force use our own JitsiMeetSDK
-  pod 'JitsiMeetSDK', :git => 'https://github.com/RocketChat/jitsi-meet-ios-sdk-releases.git'
+  pod 'JitsiMeetSDK', :git => 'https://github.com/RocketChat/jitsi-meet-ios-sdk-releases.git', :branch => '3.7'


We need to remove this branch and reinstall pods before merging

gerzonc

LGTM :)

ankar84 · 2021-08-13T18:29:14Z

Known issue: During development, I found that if you start this process from mobile and try to join on the web, it won't work. We need to test that and check if there's an open issue on the web repo.

Yeap, it's a front-end bug, that will be fixed in next release, I guess

RocketChat/Rocket.Chat#22845

ankar84 · 2021-08-13T18:35:39Z

Known issue

Sometimes Jitsi's "End call" button doesn't work (it just grey out)

When that happens, I needed to tap several times or wait until the call was ended

I was unable to find how to reproduce that 100%, but we need to test that and evaluate if it's a critical issue (if it happens too often, if the call is ended properly, etc)

And that's really strange. I didn't get that kind of bug using Jitsi meet application which on same 3.7.0 SDK version.

But I will wait RCRN Experimental beta to test it with our production Jitsi deployment and left a feedback for sure!

.circleci/config.yml

diegolmello · 2021-08-27T13:50:51Z

Downgraded to Jitsi SDK 3.6.0 and there's no ghost users or black screen.

ankar84 · 2021-08-27T16:37:33Z

Downgraded to Jitsi SDK 3.6.0 and there's no ghost users or black screen.

Good to know that! Wait to test public beta with Jitsi SDK 3.6.0!
And thanks a lot for your hard work again!

# Conflicts: # ios/Pods/Pods.xcodeproj/project.pbxproj # ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService.debug.xcconfig # ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService.release.xcconfig

# Conflicts: # ios/Pods/Pods.xcodeproj/project.pbxproj

diegolmello added 3 commits July 22, 2021 17:45

Fix RN deps

1283e4e

Update react-native-jitsi-meet

70a2f68

Working on iOS from Jitsi source

8128eb7

diegolmello added 🚧 wip ⬆️ update dependencies labels Jul 22, 2021

diegolmello added 5 commits August 2, 2021 16:34

Merge branch 'develop' into update-jitsi

2cd3354

# Conflicts: # ios/Podfile.lock # yarn.lock

Dependencies installed

1aac6f4

Temp android

8329069

Kinda working android

d87b46a

Working on iOS with our SDK

5984ccb

diegolmello force-pushed the update-jitsi branch from 105c3d6 to 5984ccb Compare August 10, 2021 16:27

diegolmello added 3 commits August 12, 2021 15:34

Use our maven repo

71443b0

Fix temp maven url

a2ab893

Cleanup

be22c94

diegolmello force-pushed the update-jitsi branch from d752315 to be22c94 Compare August 13, 2021 13:03

diegolmello commented Aug 13, 2021

View reviewed changes

This was referenced Aug 13, 2021

Update mobile branch to 3.6.0 RocketChat/jitsi-meet#14

Merged

Update to SDK 3.6.0 RocketChat/jitsi-maven-repository#2

Merged

Update to SDK 3.6.0 RocketChat/react-native-jitsi-meet#9

Merged

Update to SDK 3.6.0 RocketChat/jitsi-meet-ios-sdk-releases#5

Merged

diegolmello marked this pull request as ready for review August 13, 2021 14:20

gerzonc removed the 🚧 wip label Aug 13, 2021

gerzonc approved these changes Aug 13, 2021

View reviewed changes

ankar84 mentioned this pull request Aug 14, 2021

Update Jitsi SDK to current version #3086

Closed

diegolmello added 4 commits August 16, 2021 14:03

Fix maven url

7d082d2

Bring chat back

7da55d8

Add activity indicator

e9a1f6c

Update react-native-jitsi-meet

6d530d2

Fix loading on iOS

ec8182f

diegolmello force-pushed the update-jitsi branch from 3098cd5 to ec8182f Compare August 17, 2021 20:23

diegolmello added 2 commits August 17, 2021 17:23

Merge branch 'develop' into update-jitsi

95490d3

Clear gradle cache

dc2fe8e

diegolmello commented Aug 17, 2021

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

diegolmello added 2 commits August 26, 2021 17:10

Try 3.6.0

c0e7c95

Dummy change to update gradle cache

48774fc

diegolmello changed the title ~~Chore: Update Jitsi to 3.7.0~~ Chore: Update Jitsi to 3.6.0 Aug 27, 2021

diegolmello mentioned this pull request Aug 27, 2021

[modules/xmpp/ChatRoom.js] Error processing:avatar-url node jitsi/jitsi-meet#9784

Closed

diegolmello added 5 commits August 27, 2021 16:35

Point to merged forks

344b5c1

Merge branch 'develop' into update-jitsi

c9d1a77

# Conflicts: # ios/Pods/Pods.xcodeproj/project.pbxproj

Merge branch 'develop' into update-jitsi

aff863a

update pod commit

7cd419b

diegolmello merged commit 2c31fc2 into develop Aug 30, 2021

diegolmello deleted the update-jitsi branch August 30, 2021 14:27

ankar84 mentioned this pull request Nov 23, 2021

[ios] No Audio track when join a call muted jitsi/jitsi-meet#10415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: Update Jitsi to 3.6.0#3292

Chore: Update Jitsi to 3.6.0#3292
diegolmello merged 25 commits intodevelopfrom
update-jitsi

diegolmello commented Jul 22, 2021 •

edited

Loading

Uh oh!

diegolmello Aug 13, 2021

Uh oh!

diegolmello Aug 13, 2021

Uh oh!

diegolmello Aug 13, 2021

Uh oh!

diegolmello Aug 13, 2021

Uh oh!

diegolmello Aug 13, 2021

Uh oh!

gerzonc left a comment

Uh oh!

ankar84 commented Aug 13, 2021

Uh oh!

ankar84 commented Aug 13, 2021 •

edited

Loading

Known issue

Uh oh!

Uh oh!

diegolmello commented Aug 27, 2021 •

edited

Loading

Uh oh!

ankar84 commented Aug 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

diegolmello commented Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

How to test or reproduce

Starting a call

Joining from message

Joining from push notification

Test Jitsi features

Dark mode

Screenshots

Types of changes

Checklist

Further comments

Uh oh!

diegolmello Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

diegolmello Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

diegolmello Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

diegolmello Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

diegolmello Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

gerzonc left a comment

Choose a reason for hiding this comment

Uh oh!

ankar84 commented Aug 13, 2021

Uh oh!

ankar84 commented Aug 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Known issue

Uh oh!

Uh oh!

diegolmello commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ankar84 commented Aug 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

diegolmello commented Jul 22, 2021 •

edited

Loading

ankar84 commented Aug 13, 2021 •

edited

Loading

diegolmello commented Aug 27, 2021 •

edited

Loading