[FIX] Unarchive permission not honored#3237
Merged
diegolmello merged 10 commits intodevelopfrom Aug 16, 2021
Merged
Conversation
… capitalize lodash
diegolmello
requested changes
Jul 2, 2021
diegolmello
approved these changes
Jul 22, 2021
Member
diegolmello
left a comment
There was a problem hiding this comment.
Made a few changes and now lgtm.
@reinaldonetof Can you add a proper test plan and update the description?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implemented to show an alert error when archive/unarchives a room.
Disable the
ARCHIVE/UNARCHIVEbutton due to the role permissionIssue(s)
#3118
I archive the channel, the "Unarchive" button appears, but it does not work
How to test or reproduce
Room Info EditScreenshots
Types of changes
Checklist
Further comments
Closes #3118