[BUG] App isn't showing message for PDF/file uploads#2584
Merged
diegolmello merged 9 commits intoRocketChat:developfrom Nov 4, 2020
Merged
[BUG] App isn't showing message for PDF/file uploads#2584diegolmello merged 9 commits intoRocketChat:developfrom
diegolmello merged 9 commits intoRocketChat:developfrom
Conversation
In app/containers/message/Reply.js added a View Contaier around the Attachment Touchable and Added a Markdown attribute with msg set to description of attachment to display the message if any.
Added an if statement to check if file description exists and if yes then add a markdown with value msg equal to the description. Also tested using 'yarn test -u' to add/update the tests.
Removed the condition to check for attachment description. Added the `markdown` inside the touchable and wrapped `attachmentContainer` and the `markdown` inside a `<>` component
djorkaeffalexandre
changed the title
diegolmello
requested changes
Nov 3, 2020
Member
diegolmello
left a comment
diegolmello
left a comment
There was a problem hiding this comment.
I couldn't find the if statement mentioned on the description and markdown is rendering inside the touchable.
Contributor
Author
|
I removed the if statement as one of the maintainers told me there is no need for the if statement. I have fixed my mistake in the return statement and moved markdown outside the touchable. |
Member
|
@saket-m0 I've tweaked it a bit in order to merge. You can check my changes. Thanks. |
Contributor
Author
|
Thanks a lot! :) |
Proposed changes
The app now shows the message entered with the pdf or other files on sending.
In app/containers/message/Reply.js added an if statement to check if file description exists and if yes then add a markdown with value msg equal to the description.
Also tested using 'yarn test -u' to add/update the tests.
Issue(s)
Fixing the issue #2531
How to test or reproduce
Screenshots
The text entered while sending the file is visible in the development version now (Refer to the latest attachment sent).
The same text is not visible in the production version (Refer to the latest attachment sent).
Types of changes
Checklist
Further comments
I am new to Opensource. Please let me know if I have done something wrong so that I can Fix It. Thank You!