Skip to content

[FIX] WorkspaceView not looking for the correct image path#2376

Merged
diegolmello merged 1 commit intodevelopfrom
fix.workspace-logo
Aug 5, 2020
Merged

[FIX] WorkspaceView not looking for the correct image path#2376
diegolmello merged 1 commit intodevelopfrom
fix.workspace-logo

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Aug 5, 2020 •
edited
Loading

Proposed changes

We need to look for url and fallback to defaultUrl

Issue(s)

Closes #2371
Closes RocketChat/Rocket.Chat#18344

How to test or reproduce

Screenshots

Before

image

After

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Co-authored-by: Gabriel Henriques [email protected]

@diegolmello diegolmello mentioned this pull request Aug 5, 2020
Closed
djorkaeffalexandre
djorkaeffalexandre approved these changes Aug 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@diegolmello diegolmello merged commit 71a809a into develop Aug 5, 2020
@diegolmello diegolmello deleted the fix.workspace-logo branch August 5, 2020 16:46
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445