Skip to content

[FIX] Quote not working on Group DM#2372

Merged
diegolmello merged 2 commits intodevelopfrom
fix.quote-group-dm
Aug 5, 2020
Merged

[FIX] Quote not working on Group DM#2372
diegolmello merged 2 commits intodevelopfrom
fix.quote-group-dm

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Aug 5, 2020

Proposed changes

Quote on Group DMs should be using room.rid instead of room.name.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

djorkaeffalexandre
djorkaeffalexandre approved these changes Aug 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit f0d9c92 into develop Aug 5, 2020
@diegolmello diegolmello deleted the fix.quote-group-dm branch August 5, 2020 16:48
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445