Skip to content

[IMPROVEMENT] Use parsed EJSON info on load notification#2370

Merged
diegolmello merged 1 commit intodevelopfrom
improvement.ejson
Aug 4, 2020
Merged

[IMPROVEMENT] Use parsed EJSON info on load notification#2370
diegolmello merged 1 commit intodevelopfrom
improvement.ejson

Conversation

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

Proposed changes

Instead of create a new sharedPreferences instance to read user credentials we can use the EJSON class that have the logic to get these values from a notification.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello merged commit 0f0e2c7 into develop Aug 4, 2020
@diegolmello diegolmello deleted the improvement.ejson branch August 4, 2020 20:39