Skip to content

[CHORE] Wrap logEvent in a try/catch#2361

Merged
diegolmello merged 2 commits intoRocketChat:developfrom
youssef-md:chore.handle-exception-logEvent
Jul 31, 2020
Merged

[CHORE] Wrap logEvent in a try/catch#2361
diegolmello merged 2 commits intoRocketChat:developfrom
youssef-md:chore.handle-exception-logEvent

Conversation

@youssef-md
Copy link
Copy Markdown
Contributor

@youssef-md youssef-md commented Jul 30, 2020 •
edited
Loading

Proposed changes

Wraps the logEvent() method in a try/catch block in case of any thrown exception by analytics().logEvent() or leaveBreadcrumb()

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@diegolmello diegolmello changed the title [CHORE] Handle a thrown exception in the logEvent method [CHORE] Wrap logEvent in a try/catch Jul 31, 2020
diegolmello
diegolmello approved these changes Jul 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 4787821 into RocketChat:develop Jul 31, 2020
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445