[FIX] App hanging on splash screen when deep link params are wrong#2359
Merged
diegolmello merged 3 commits intodevelopfrom Jul 30, 2020
Merged
[FIX] App hanging on splash screen when deep link params are wrong#2359diegolmello merged 3 commits intodevelopfrom
diegolmello merged 3 commits intodevelopfrom
Proposed changes
As our app answers to
https://go.rocket.chatandrocketchat://, we have to follow some rules in order to deep link users to the wanted room or server.There're some cases that this deep link is wrong, incomplete, with an invalid server, etc.
Previous to this PR, we were just stopping the execution of the process, but that would leave the user stuck on the splash screen, if the app was closed.
This PR checks if the app is opened and, if not, calls
appInit(), making the app to start over.Issue(s)
Closes #1626
How to test or reproduce
Test plan
xcrun simctl openurl booted rocketchat://room\?WHATEVER\=open.rocket.chatappInit()againxcrun simctl openurl booted rocketchat://room\?WHATEVER\=open.rocket.chatreturnxcrun simctl openurl booted rocketchat://room\?host\=asd.rocket.chatappInit()Screenshots
Types of changes
Checklist
Further comments