Skip to content

[FIX] Add missing keys to push get payload#2358

Merged
diegolmello merged 1 commit intodevelopfrom
fix.missing-not-keys
Jul 30, 2020
Merged

[FIX] Add missing keys to push get payload#2358
diegolmello merged 1 commit intodevelopfrom
fix.missing-not-keys

Conversation

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre commented Jul 30, 2020

Proposed changes

When notification is idOnly we should add all the content to the object that will be sent to the JS land, so, we need to be sure to add all the notification properties like when this is sent with the payload-in.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello merged commit 8cd38d5 into develop Jul 30, 2020
@diegolmello diegolmello deleted the fix.missing-not-keys branch July 30, 2020 17:10
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445