Skip to content

[FIX] Long press gestures not working properly on Android#2354

Merged
diegolmello merged 2 commits intodevelopfrom
fix.long-press-gesture
Jul 29, 2020
Merged

[FIX] Long press gestures not working properly on Android#2354
diegolmello merged 2 commits intodevelopfrom
fix.long-press-gesture

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Jul 29, 2020 •
edited
Loading

Proposed changes

There're a couple of places we use LongPressGestureHandler and it looks like it doesn't work all the time on Android.
This PR starts using the new Pressable component to replace these cases.

As a future PR, we need to replace all Touchable* components with this new option and maybe refactor our touch util to use it as well.

Issue(s)

How to test or reproduce

Test plan

  • Delete server both on iOS and Android
  • Mute user on RoomMembersView
  • Detox tests must pass

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

djorkaeffalexandre
djorkaeffalexandre approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since Pressable looks good, let's change all places soon :)

@diegolmello diegolmello merged commit a584e68 into develop Jul 29, 2020
@diegolmello diegolmello deleted the fix.long-press-gesture branch July 29, 2020 21:03
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445