Skip to content

[FIX] In-app notification showing while in a Jitsi call#2345

Merged
diegolmello merged 4 commits intoRocketChat:developfrom
youssef-md:fix.hide-notification-inside-jitsi-call
Jul 29, 2020
Merged

[FIX] In-app notification showing while in a Jitsi call#2345
diegolmello merged 4 commits intoRocketChat:developfrom
youssef-md:fix.hide-notification-inside-jitsi-call

Conversation

@youssef-md
Copy link
Copy Markdown
Contributor

@youssef-md youssef-md commented Jul 28, 2020

Proposed changes

The issue #2285 references a bug, when tapping in an in-app notification the jitsi call ends. To fix this behavior a solution is to not show the notification when the user is focused on the JitsiMeetView.

Issue(s)

#2285

How to test or reproduce

Enter in a Jitsi call in your mobile client, receive a message, it won't be shown for you to press and end the call.

Screenshots

ezgif com-gif-maker (1)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@youssef-md youssef-md changed the title Hide in app notification when in a Jitsi call Hide in-app notification when in a Jitsi call Jul 28, 2020
diegolmello
diegolmello requested changes Jul 28, 2020
View reviewed changes
@diegolmello diegolmello changed the title Hide in-app notification when in a Jitsi call [FIX] In-app notification showing while in a Jitsi call Jul 28, 2020
diegolmello
diegolmello approved these changes Jul 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 052d91e into RocketChat:develop Jul 29, 2020
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445