Skip to content

[IMPROVEMENT] TwoFactor component styling#2328

Merged
diegolmello merged 8 commits intoRocketChat:developfrom
youssef-md:improve.2fa-styling
Jul 22, 2020
Merged

[IMPROVEMENT] TwoFactor component styling#2328
diegolmello merged 8 commits intoRocketChat:developfrom
youssef-md:improve.2fa-styling

Conversation

@youssef-md
Copy link
Copy Markdown
Contributor

@youssef-md youssef-md commented Jul 21, 2020 •
edited
Loading

Proposed changes

This PR improves the TwoFactor component styling to enhance visual hierarchy.

Issues

Depends on #2314

How to test or reproduce

Set 2fa in your account, and login again.

Screenshots

Group 797 (1)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

djorkaeffalexandre
djorkaeffalexandre suggested changes Jul 21, 2020
View reviewed changes
@youssef-md youssef-md force-pushed the improve.2fa-styling branch from 055978d to 98ccf2b Compare July 21, 2020 20:55
@youssef-md youssef-md force-pushed the improve.2fa-styling branch from 98ccf2b to f079c99 Compare July 21, 2020 21:04
diegolmello
diegolmello approved these changes Jul 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 95e228e into RocketChat:develop Jul 22, 2020
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445