Skip to content

[FIX] Room Info actions doesn't check permissions/settings enabled#2292

Merged
diegolmello merged 5 commits intodevelopfrom
fix.room-info
Jul 17, 2020
Merged

[FIX] Room Info actions doesn't check permissions/settings enabled#2292
diegolmello merged 5 commits intodevelopfrom
fix.room-info

Conversation

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre commented Jul 15, 2020

@RocketChat/ReactNative

  1. Check if Jitsi is enabled to show the Jitsi Call button
  2. Show info of the user even the direct can't be created
  3. Don't allow user to navigate to DM if it's not possible
  4. Don't create the DM before the user click on some action
    I'm using the same behavior of the web client about the Direct Message button, showing a toast when the direct message can't be created due permissions.

@diegolmello diegolmello merged commit c6401a2 into develop Jul 17, 2020
@diegolmello diegolmello deleted the fix.room-info branch July 17, 2020 17:08
@diegolmello diegolmello mentioned this pull request Aug 25, 2020
Closed
diegolmello added a commit that referenced this pull request Sep 1, 2020
@diegolmello @djorkaeffalexandre
@youssef-md @Prateek93a @phriedrich @sarthakpranesh @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot @refactor-droidyy @grahamsmith @gabriellsh @juliagrala
Merge beta into master (#2445