Skip to content

[FIX] getSettings not catching errors#2271

Merged
diegolmello merged 1 commit intodevelopfrom
fix.get-settings-share-extension
Jul 9, 2020
Merged

[FIX] getSettings not catching errors#2271
diegolmello merged 1 commit intodevelopfrom
fix.get-settings-share-extension

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Jul 9, 2020

@RocketChat/ReactNative

I removed InteractionManager, which makes try/catch not work properly.

@diegolmello diegolmello force-pushed the fix.get-settings-share-extension branch from 13a70de to 205b145 Compare July 9, 2020 13:22
djorkaeffalexandre
djorkaeffalexandre approved these changes Jul 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit f3b02a6 into develop Jul 9, 2020
@diegolmello diegolmello deleted the fix.get-settings-share-extension branch July 9, 2020 13:33
diegolmello added a commit that referenced this pull request Jul 9, 2020
@diegolmello
[FIX] getSettings not catching errors (#2271)
0ecfe0f
diegolmello added a commit that referenced this pull request Jul 17, 2020
@diegolmello @Daanchaam
@djorkaeffalexandre @youssef-md @ivanape @Prateek93a @sarthakpranesh @phriedrich @tanmoyopenroot @hibikine @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot
Merge beta into master (#2309)
0c7a9b9 
* [i18n] Added Dutch translation (#1676)

* [NEW] Omnichannel Beta (#1674)

* [NEW] Confirm logout/clear cache (#1688)

* [I18N] Add es-ES language  (#1495)

* [NEW] UiKit Beta (#1497)

* [IMPROVEMENT] Use reselect (#1696)

* [FIX] Notification in Android API level less than 24 (#1692)

* [IMPROVEMENT] Send tmid on slash commands and media (#1698)

* [FIX] Unhandled action on UIKit (#1703)

* [NEW] Pull to refresh RoomsList (#1701)

* [IMPROVEMENT] Reset app when language is changed (#1702)

* [FIX] Small fixes on UIKit (#1709)

* [FIX] Spotlight (#1719)

* [CHORE] Update react-native-image-crop-picker (#1712)

* [FIX] Messages Overlapping (Android) and MessageBox Scroll (iOS) (#1720)

* [REGRESSION] Remove @ and # from mention (#1721)

* [NEW] Direct message from user info (#1516)

* [FIX] Delete slash commands (#1723)

* [IMPROVEMENT] Hold URL to copy (#1684)

* [FIX] Different sourcemaps generation for Hermes (#1724)

* [FIX] Different sourcemaps generation for Hermes

* Upload sourcemaps after build

* [REVERT] Show emoji keyboard on Android (#1738)

* [FIX] Stop logging react-native-image-crop-picker (#1745)

* [FIX] Prevent toast ref error (#1744)

* [FIX] Prevent reaction map error (#1743)

* [FIX] Add missing calls to user info (#1741)

* [FIX] Catch room unsubscribe error (#1739)

* [i18n] Missing German keys (#1735)

* [FIX] Missing i18n on MessagesView title (#1733)

* [FIX]  UIKit Modal: Weird behavior on Android Tablet (#1742)

* [i18n] Missing key on German (#1747)

Co-authored-by: Diego Mello <[email protected]>

* [i18n] Add Italian (#1736)

* [CHORE] Memory leaks investigation (#1675)

* [IMPROVEMENT] Alert verify email when enabled (#1725)

* [NEW] Jitsi JWT added to URL (#1746)

* [FIX] UIKit submit when connection lost (