Skip to content

[FIX] Navigation object undefined when tapping sidebar's user header on tablet#2259

Merged
diegolmello merged 2 commits intodevelopfrom
fix.close-drawer-ipad
Jul 8, 2020
Merged

[FIX] Navigation object undefined when tapping sidebar's user header on tablet#2259
diegolmello merged 2 commits intodevelopfrom
fix.close-drawer-ipad

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Jul 8, 2020

@RocketChat/ReactNative

It was trying to close a nonexistent drawer on isMasterDetail layout.
I removed the functionality, because there's a close modal button for that.

Test plan

Mobile

  • Open drawer
  • Tap user header
  • It should close the drawer

Tablet

  • Open drawer (which is a modal on this case)
  • Tap user header
  • It shouldn't do anything

djorkaeffalexandre
djorkaeffalexandre approved these changes Jul 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit afb0707 into develop Jul 8, 2020
@diegolmello diegolmello deleted the fix.close-drawer-ipad branch July 8, 2020 19:40
diegolmello added a commit that referenced this pull request Jul 8, 2020
@diegolmello
[FIX] Navigation object undefined when tapping sidebar's user header …
3d987cc 
…on tablet (#2259)
diegolmello added a commit that referenced this pull request Jul 17, 2020
@diegolmello @Daanchaam
@djorkaeffalexandre @youssef-md @ivanape @Prateek93a @sarthakpranesh @phriedrich @tanmoyopenroot @hibikine @devyaniChoubey @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler @snyk-bot
Merge beta into master (#2309)
0c7a9b9 
* [i18n] Added Dutch translation (#1676)

* [NEW] Omnichannel Beta (#1674)

* [NEW] Confirm logout/clear cache (#1688)

* [I18N] Add es-ES language  (#1495)

* [NEW] UiKit Beta (#1497)

* [IMPROVEMENT] Use reselect (#1696)

* [FIX] Notification in Android API level less than 24 (#1692)

* [IMPROVEMENT] Send tmid on slash commands and media (#1698)

* [FIX] Unhandled action on UIKit (#1703)

* [NEW] Pull to refresh RoomsList (#1701)

* [IMPROVEMENT] Reset app when language is changed (#1702)

* [FIX] Small fixes on UIKit (#1709)

* [FIX] Spotlight (#1719)

* [CHORE] Update react-native-image-crop-picker (#1712)

* [FIX] Messages Overlapping (Android) and MessageBox Scroll (iOS) (#1720)

* [REGRESSION] Remove @ and # from mention (#1721)

* [NEW] Direct message from user info (#1516)

* [FIX] Delete slash commands (#1723)

* [IMPROVEMENT] Hold URL to copy (#1684)

* [FIX] Different sourcemaps generation for Hermes (#1724)

* [FIX] Different sourcemaps generation for Hermes

* Upload sourcemaps after build

* [REVERT] Show emoji keyboard on Android (#1738)

* [FIX] Stop logging react-native-image-crop-picker (#1745)

* [FIX] Prevent toast ref error (#1744)

* [FIX] Prevent reaction map error (#1743)

* [FIX] Add missing calls to user info (#1741)

* [FIX] Catch room unsubscribe error (#1739)

* [i18n] Missing German keys (#1735)

* [FIX] Missing i18n on MessagesView title (#1733)

* [FIX]  UIKit Modal: Weird behavior on Android Tablet (#1742)

* [i18n] Missing key on German (#1747)

Co-authored-by: Diego Mello <[email protected]>

* [i18n] Add Italian (#1736)

* [CHORE] Memor