Skip to content

[FIX] ThreadMessagesView throwing error when subscription wasn't found#2255

Merged
diegolmello merged 2 commits intodevelopfrom
fix.thread-messages
Jul 8, 2020
Merged

[FIX] ThreadMessagesView throwing error when subscription wasn't found#2255
diegolmello merged 2 commits intodevelopfrom
fix.thread-messages

Conversation

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre commented Jul 8, 2020

@RocketChat/ReactNative

Test Plan

  • Go to directory
  • Open a room that you don't have joined yet
  • Open thread messages view

@djorkaeffalexandre djorkaeffalexandre changed the title [FIX] ThreadMessagesView init when subscription was not found yet [FIX] ThreadMessagesView init when subscription was not found Jul 8, 2020
@diegolmello diegolmello changed the title [FIX] ThreadMessagesView init when subscription was not found [FIX] ThreadMessagesView throwing error when subscription wasn't found Jul 8, 2020
@diegolmello diegolmello merged commit ef68f16 into develop Jul 8, 2020
@diegolmello diegolmello deleted the fix.thread-messages branch July 8, 2020 16:50
diegolmello added a commit that referenced this pull request Jul 8, 2020
diegolmello added a commit that referenced this pull request Jul 17, 2020
* [i18n] Added Dutch translation (#1676)

* [NEW] Omnichannel Beta (#1674)

* [NEW] Confirm logout/clear cache (#1688)

* [I18N] Add es-ES language  (#1495)

* [NEW] UiKit Beta (#1497)

* [IMPROVEMENT] Use reselect (#1696)

* [FIX] Notification in Android API level less than 24 (#1692)

* [IMPROVEMENT] Send tmid on slash commands and media (#1698)

* [FIX] Unhandled action on UIKit (#1703)

* [NEW] Pull to refresh RoomsList (#1701)

* [IMPROVEMENT] Reset app when language is changed (#1702)

* [FIX] Small fixes on UIKit (#1709)

* [FIX] Spotlight (#1719)

* [CHORE] Update react-native-image-crop-picker (#1712)

* [FIX] Messages Overlapping (Android) and MessageBox Scroll (iOS) (#1720)

* [REGRESSION] Remove @ and # from mention (#1721)

* [NEW] Direct message from user info (#1516)

* [FIX] Delete slash commands (#1723)

* [IMPROVEMENT] Hold URL to copy (#1684)

* [FIX] Different sourcemaps generation for Hermes (#1724)

* [FIX] Different sourcemaps generation for Hermes

* Upload sourcemaps after build

* [REVERT] Show emoji keyboard on Android (#1738)

* [FIX] Stop logging react-native-image-crop-picker (#1745)

* [FIX] Prevent toast ref error (#1744)

* [FIX] Prevent reaction map error (#1743)

* [FIX] Add missing calls to user info (#1741)

* [FIX] Catch room unsubscribe error (#1739)

* [i18n] Missing German keys (#1735)

* [FIX] Missing i18n on MessagesView title (#1733)

* [FIX]  UIKit Modal: Weird behavior on Android Tablet (#1742)

* [i18n] Missing key on German (#1747)

Co-authored-by: Diego Mello <[email protected]>

* [i18n] Add Italian (#1736)

* [CHORE] Memory leaks investigation (#1675)

* [IMPROVEMENT] Alert verify email when enabled (#1725)

* [NEW] Jitsi JWT added to URL (#1746)

* [FIX] UIKit submit when connection lost (#1748)

* Bump version to 4.5.0 (#1761)

* [NEW] Default browser (#1752)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] HTTP Basic Auth (#1753)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Honor profile fields edit settings (#1687)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Room announcements (#1726)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Honor Register/Login settings (#1727)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Make links clickable on Room Info (#1730)

Co-authored-by: Diego Mello <[email protected]>

* [NEW] Hide system messages (#1755)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Honor "Message_AudioRecorderEnabled" (#1764)

Co-authored-by: Diego Mello <[email protected]>

* [i18n] Missing de keys (#1765)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Redirect user to SetUsernameView (#1728)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Join Room (#1769)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Accept all media types using * (#1770)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Use RealName when necessary (#1758)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Markdown Line Break (#1783)

* [IMPROVEMENT] Remove useMarkdown (#1774)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Open browser rather than webview on Create Workspace (#1788)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Markdown perf (