Skip to content

[FIX] AttachmentView crashing during title decode#2253

Merged
diegolmello merged 2 commits intodevelopfrom
fix.attachment-title
Jul 8, 2020
Merged

[FIX] AttachmentView crashing during title decode#2253
diegolmello merged 2 commits intodevelopfrom
fix.attachment-title

Conversation

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

@RocketChat/ReactNative

decodeURI can throw an error while try to decode filename, so, we'll use the original title at these cases.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Malformed_URI

@diegolmello diegolmello changed the title [FIX] AttachmentView crashing while try to decode attachment title [FIX] AttachmentView crashing during title decode Jul 8, 2020
@diegolmello diegolmello merged commit 5b3be4e into develop Jul 8, 2020
@diegolmello diegolmello deleted the fix.attachment-title branch July 8, 2020 16:40
diegolmello added a commit that referenced this pull request Jul 8, 2020
diegolmello added a commit that referenced this pull request Jul 17, 2020
* [i18n] Added Dutch translation (#1676)

* [NEW] Omnichannel Beta (#1674)

* [NEW] Confirm logout/clear cache (#1688)

* [I18N] Add es-ES language  (#1495)

* [NEW] UiKit Beta (#1497)

* [IMPROVEMENT] Use reselect (#1696)

* [FIX] Notification in Android API level less than 24 (#1692)

* [IMPROVEMENT] Send tmid on slash commands and media (#1698)

* [FIX] Unhandled action on UIKit (#1703)

* [NEW] Pull to refresh RoomsList (#1701)

* [IMPROVEMENT] Reset app when language is changed (#1702)

* [FIX] Small fixes on UIKit (#1709)

* [FIX] Spotlight (#1719)

* [CHORE] Update react-native-image-crop-picker (#1712)

* [FIX] Messages Overlapping (Android) and MessageBox Scroll (iOS) (#1720)

* [REGRESSION] Remove @ and # from mention (#1721)

* [NEW] Direct message from user info (#1516)

* [FIX] Delete slash commands (#1723)

* [IMPROVEMENT] Hold URL to copy (#1684)

* [FIX] Different sourcemaps generation for Hermes (#1724)

* [FIX] Different sourcemaps generation for Hermes

* Upload sourcemaps after build

* [REVERT] Show emoji keyboard on Android (#1738)

* [FIX] Stop logging react-native-image-crop-picker (#1745)

* [FIX] Prevent toast ref error (#1744)

* [FIX] Prevent reaction map error (#1743)

* [FIX] Add missing calls to user info (#1741)

* [FIX] Catch room unsubscribe error (#1739)

* [i18n] Missing German keys (#1735)

* [FIX] Missing i18n on MessagesView title (#1733)

* [FIX]  UIKit Modal: Weird behavior on Android Tablet (#1742)

* [i18n] Missing key on German (#1747)

Co-authored-by: Diego Mello <[email protected]>

* [i18n] Add Italian (#1736)

* [CHORE] Memory leaks investigation (#1675)

* [IMPROVEMENT] Alert verify email when enabled (#1725)

* [NEW] Jitsi JWT added to URL (#1746)

* [FIX] UIKit submit when connection lost (#1748)

* Bump version to 4.5.0 (#1761)

* [NEW] Default browser (#1752)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] HTTP Basic Auth (#1753)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Honor profile fields edit settings (#1687)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Room announcements (#1726)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Honor Register/Login settings (#1727)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Make links clickable on Room Info (#1730)

Co-authored-by: Diego Mello <[email protected]>

* [NEW] Hide system messages (#1755)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Honor "Message_AudioRecorderEnabled" (#1764)

Co-authored-by: Diego Mello <[email protected]>

* [i18n] Missing de keys (#1765)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Redirect user to SetUsernameView (#1728)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Join Room (#1769)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Accept all media types using * (#1770)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Use RealName when necessary (#1758)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Markdown Line Break (#1783)

* [IMPROVEMENT] Remove useMarkdown (#1774)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Open browser rather than webview on Create Workspace (#1788)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Markdown perf (#1796)

* [FIX] Stop video when modal is closed (#1787)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Hide reply notification action when there are missing data (#1771)

Co-authored-by: Diego Mello <[email protected]>

* [i18n] Added Japanese translation (#1781)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Reset password error message (#1772)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Close tablet modal (#1773)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Setting not present (#1775)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Thread header (#1776)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Keyboard tracking loses input ref (#1784)

Co-authored-by: Diego Mello <[email protected]>

* [NEW] Mark message as unread (#1785)

Co-authored-by: Djorkaeff Alexandre <[email protected]>

* [IMPROVEMENT] Log server version (#1786)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Add loading message on long running tasks (#1798)

Co-authored-by: Diego Mello <[email protected]>

* [CHORE] Switch Apple account on Fastlane (#1810)

* [FIX] Watermelon throwing "Cannot update a record with pending updates" (#1754)

* [FIX] Detox tests (#1790)

* [CHORE] Use markdown preview on RoomView Header (#1807)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] LoginSignup blink services (#1809)

Co-authored-by: Diego Mello <[email protected]>

* [IMPROVEMENT] Request user presence on demand (#1813)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Remove a