Skip to content

[NEW] Log events from RoomsList, SideDrawer and Profile#2190

Merged
diegolmello merged 45 commits intoRocketChat:developfrom
youssef-md:new.track-roomslist-sidedrawer-profile
Jul 30, 2020
Merged

[NEW] Log events from RoomsList, SideDrawer and Profile#2190
diegolmello merged 45 commits intoRocketChat:developfrom
youssef-md:new.track-roomslist-sidedrawer-profile

Conversation

@youssef-md
Copy link
Copy Markdown
Contributor

@youssef-md youssef-md commented Jun 14, 2020

@RocketChat/ReactNative

Depends on #2169

  • All events now start with the View responsible for that action.

Login/Register View:

  • Changed all LOGIN_WITH_... to ENTER_WITH_...
  • Enter with Apple(handle fail event);

RoomsListView:

  • Toggle server dropdown;
  • Add server;
  • Change server;
  • Navigate to NewMessageView;
  • RoomsList search;
  • Navigate to DirectoryView;
  • Toggle sort dropdown;
  • Sort by Name;
  • Sort by Activity;
  • Group by type;
  • Group favorites;
  • Unread on top;
  • Go to room;
  • Favorite/Unfavorite a channel (handle fail event);
  • Read/Unread a channel (handle fail event);
  • Hide channel (handle fail event);

DirectoryView:

  • Show channels;
  • Show users;

NewMessage:

  • Chat with user;
  • Create channel;
  • Create group chat;
  • Create discussion;

SelectedUsersView:

  • Add user;
  • Remove user;
  • Create group(handle fail event);

CreateChannelView:

  • Create a channel(handle fail event);
  • Toggle type;
  • Toggle read only;
  • Toggle broadcast;
  • Remove user;

CreateDiscussionView:

  • Create a discussion(handle fail event);
  • Select channel;
  • Select users;

SibebarView:

  • Navigate to Status;
  • Navigate to Chats;
  • Navigate to Profile;
  • Navigate to Settings;
  • Navigate to AdmPanel;

ProfileView:

  • Pick profile avatar (handle fail event);
  • Pick profile avatar with URL;
  • Save profile avatar (handle fail event);
  • Save profile changes (handle fail event);

@youssef-md youssef-md marked this pull request as draft June 14, 2020 20:02
@youssef-md youssef-md changed the title [WIP] Track roomslist sidedrawer profile [NEW] Track RoomsList, SideDrawer and Profile Jun 15, 2020
@youssef-md youssef-md marked this pull request as ready for review June 15, 2020 04:26
@youssef-md youssef-md changed the title [NEW] Track RoomsList, SideDrawer and Profile [NEW] Log events from RoomsList, SideDrawer and Profile Jun 21, 2020
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Change all events to identify the component/screen
  • Make sure you're not reusing events
  • Log trivial events like:
    • Open/close sort dropdown
    • Open/close server dropdown

@youssef-md
Copy link
Copy Markdown
Contributor Author

youssef-md commented Jul 27, 2020

  • Change all events to identify the component/screen

  • Make sure you're not reusing events

  • Log trivial events like:

    • Open/close sort dropdown
    • Open/close server dropdown

I've refactored and added events that I should have logged. It's way better now.

Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit e05aa1e into RocketChat:develop Jul 30, 2020
@youssef-md youssef-md mentioned this pull request Aug 4, 2020
54 tasks