Skip to content

Markdown linting for e2e README#2173

Merged
diegolmello merged 2 commits intoRocketChat:developfrom
Fishbowler:e2e_readme_linting
Jun 9, 2020
Merged

Markdown linting for e2e README#2173
diegolmello merged 2 commits intoRocketChat:developfrom
Fishbowler:e2e_readme_linting

Conversation

@Fishbowler
Copy link
Copy Markdown
Contributor

@Fishbowler Fishbowler commented Jun 8, 2020

Simple markdown tweaks driven by linting to improve rendering (and quieten the IDE)

diegolmello
diegolmello requested changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally forgot about this file on #2012
As you can see here, I separated tests to make them easier to understand.
That's what lacks on this PR: a mention to those separated tests.

Also, should we just mention this file on main readme instead of that block with commands?

Thanks!

@Fishbowler
Copy link
Copy Markdown
Contributor Author

Fishbowler commented Jun 9, 2020

@diegolmello Fixed, I think?

diegolmello
diegolmello approved these changes Jun 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 1fa1ddd into RocketChat:develop Jun 9, 2020
@Fishbowler Fishbowler deleted the e2e_readme_linting branch June 9, 2020 19:06
diegolmello added a commit that referenced this pull request Jul 6, 2020
@diegolmello @phriedrich
@devyaniChoubey @Prateek93a @ssbing99 @djorkaeffalexandre @ura14h @Exordian @Daanchaam @youssef-md @ivanape @sarthakpranesh @tanmoyopenroot @hibikine @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler
Merge beta into master (#2246)
0a67aae 
* [FIX] Set the http-agent to the form that Rocket.Chat requires for logging (#1482)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] "Following thread" and "Unfollowed Thread" is hardcoded and not translated (#1625)

* [FIX] Disable reset button if form didn't changed (#1569)

Co-authored-by: Diego Mello <[email protected]>

* [FIX] Header title of RoomInfoView (#1553)

* [I18N] Gallery Permissions DE (#1542)

* [FIX] Not allow to send messages to archived room (#1623)

* [FIX] Profile fields automatically reset (#1502)

* [FIX] Show attachment on ThreadMessagesView (#1493)

* [NEW] Wordpress auth (#1633)

* [CHORE] Add Start Packager script (#1639)

* [CHORE] Update RN to 0.61.5 (#1638)

* [CHORE] Update RN to 0.61.5

* [CHORE] Update react-native patch

Co-authored-by: Djorkaeff Alexandre <[email protected]>

* Bump version to 4.3.1 (#1641)

* [FIX] Change force logout rule (#1640)

* Bump version to 4.4.0 (#1643)

* [IMPROVEMENT] Use MessagingStyle on Android Notification (#1575)

* [NEW] Request review (#1627)

* [NEW] Pull to refresh RoomView (#1657)

* [FIX] Unsubscribe from room (#1655)

* [FIX] Server with subdirs (#1646)

* [NEW] Clear cache (#1660)

* [IMPROVEMENT] Memoize and batch subscriptions updates (#1642)

* [FIX] Disallow empty sharing (#1664)

* [REGRESSION] Use HTTPS links for sharing and markets protocol for review (<