Skip to content

[NEW] Log events from Onboarding, NewServer, Login and Register screens#2169

Merged
diegolmello merged 17 commits intoRocketChat:developfrom
youssef-md:new.track-onboarding-workspaces-login
Jul 22, 2020
Merged

[NEW] Log events from Onboarding, NewServer, Login and Register screens#2169
diegolmello merged 17 commits intoRocketChat:developfrom
youssef-md:new.track-onboarding-workspaces-login

Conversation

@youssef-md
Copy link
Copy Markdown
Contributor

@youssef-md youssef-md commented Jun 8, 2020

What was done in this PR:

  • Creation of logEvent method to isolate to logic to improve future maintenance.
  • File /utils/log/events.js to define all the current events, to easily find them and to prevent typo if an event would be used in multiple places.

OnboardingView:

  • Join a workspace.
  • Create new Workspace(with fail event).

NewServerView:

  • Connect to typed workspace URL(with fail event).
  • Join the open workspace.

LoginServices:

  • Log all the coded OAuth options.

LoginView:

  • Log the default login(with fail event).

RegisterView:

  • Log the default sign up(with fail event).

Since Firebase Analytics Events can take a while to appear to the dashboard, I'll be using the Analytics Debug View to test the event sending.

Here is a screenshot of Analytics Debug View with all the tracked events in this PR:
Screenshot from 2020-06-08 00-38-57

user_engagement and screen_view are default Firebase events, in this screenshot I selected the join_open_workspace event to show all the default payloads, the best one is firebase_screen which references the screen that the selected event was triggered.

@youssef-md youssef-md changed the title [NEW] Track Onboarding, NewServer, Login and Register screens [NEW] Log events from Onboarding, NewServer, Login and Register screens Jun 21, 2020
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit fc324ed into RocketChat:develop Jul 22, 2020
@youssef-md youssef-md mentioned this pull request Aug 4, 2020
54 tasks