Skip to content

[CHORE] Update react-navigation to v5#2154

Merged
diegolmello merged 132 commits intodevelopfrom
update-rn-5
Jun 15, 2020
Merged

[CHORE] Update react-navigation to v5#2154
diegolmello merged 132 commits intodevelopfrom
update-rn-5

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented May 28, 2020

@RocketChat/ReactNative

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 12, 2020

This pull request introduces 1 alert and fixes 2 when merging 798bbc8 into 2cc599c - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

fixed alerts:

  • 2 for Use of returnless function

djorkaeffalexandre
djorkaeffalexandre suggested changes Jun 12, 2020
View reviewed changes
djorkaeffalexandre
djorkaeffalexandre approved these changes Jun 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 15, 2020

This pull request introduces 1 alert and fixes 2 when merging 60288dc into 5dcf221 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

fixed alerts:

  • 2 for Use of returnless function

@diegolmello diegolmello merged commit 98ed84b into develop Jun 15, 2020
@diegolmello diegolmello deleted the update-rn-5 branch June 15, 2020 14:00
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jun 15, 2020

This pull request introduces 1 alert and fixes 2 when merging ef81cec into 5dcf221 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

fixed alerts:

  • 2 for Use of returnless function

diegolmello added a commit that referenced this pull request Jul 6, 2020
@diegolmello @phriedrich
@devyaniChoubey @Prateek93a @ssbing99 @djorkaeffalexandre @ura14h @Exordian @Daanchaam @youssef-md @ivanape @sarthakpranesh @tanmoyopenroot @hibikine @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler