Skip to content

[CHORE] Create DimensionsContext#2098

Merged
diegolmello merged 12 commits intoRocketChat:developfrom
EzequielDeOliveira:DimensionsMiddleware
Jun 17, 2020
Merged

[CHORE] Create DimensionsContext#2098
diegolmello merged 12 commits intoRocketChat:developfrom
EzequielDeOliveira:DimensionsMiddleware

Conversation

@EzequielDeOliveira
Copy link
Copy Markdown
Contributor

@EzequielDeOliveira EzequielDeOliveira commented May 9, 2020 •
edited by diegolmello
Loading

@RocketChat/reactnative

This pr removes react-native-responsive-ui and creates middleware to listen the dimensions of the window and provide it through redux.

@EzequielDeOliveira
Create middleware and action and reduce
adfd800 
Signed-off-by: Ezequiel De Oliveira <[email protected]>
@EzequielDeOliveira
Apply middleware
acefdd9 
Signed-off-by: Ezequiel De Oliveira <[email protected]>
@EzequielDeOliveira
Save dimensions in store
a43385b 
Signed-off-by: Ezequiel De Oliveira <[email protected]>
@EzequielDeOliveira
Change lib for props
89bc164 
Signed-off-by: Ezequiel De Oliveira <[email protected]>
@EzequielDeOliveira
react-native-responsive-ui removed
4f2f206 
Signed-off-by: Ezequiel De Oliveira <[email protected]>
@EzequielDeOliveira EzequielDeOliveira changed the title [WIP] Use middleware instead of lib [NEW] Use middleware instead of lib May 12, 2020
diegolmello
diegolmello requested changes May 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also check for usage of Dimensions directly and use your new reducer instead.

Example:
https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/develop/app/views/RoomsListView/index.js#L186

@diegolmello diegolmello changed the title [NEW] Use middleware instead of lib [CHORE] Use redux middleware instead of react-native-responsive-ui May 25, 2020
EzequielDeOliveira and others added 5 commits May 27, 2020 02:18
@EzequielDeOliveira
Using dimensions middleware instead of directly Dimensions.get
a431806 
Signed-off-by: Ezequiel De Oliveira <[email protected]>
@EzequielDeOliveira
Removing setTimeout in the Dimensions middleware
94c115a 
Signed-off-by: Ezequiel De Oliveira <[email protected]>
@diegolmello
Merge branch 'develop' into DimensionsMiddleware
84774de 
# Conflicts:
#	app/containers/MessageBox/UploadModal.js
#	app/containers/MessageBox/index.js
#	app/containers/message/Audio.js
#	app/notifications/inApp/index.js
#	app/views/RoomView/ReactionPicker.js
#	app/views/RoomsListView/index.js
#	package.json
#	yarn.lock
@diegolmello
useDimensions and useOrientation
e0bd6bc
@diegolmello
DimensionsContext
cb105fe
@diegolmello diegolmello changed the title [CHORE] Use redux middleware instead of react-native-responsive-ui [CHORE] Create DimensionsContext Jun 17, 2020
@diegolmello diegolmello merged commit 36b37eb into RocketChat:develop Jun 17, 2020
diegolmello added a commit that referenced this pull request Jul 6, 2020
@diegolmello @phriedrich
@devyaniChoubey @Prateek93a @ssbing99 @djorkaeffalexandre @ura14h @Exordian @Daanchaam @youssef-md @ivanape @sarthakpranesh @tanmoyopenroot @hibikine @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios @Fishbowler
Merge beta into master (#2246