Skip to content

[FIX] Big names overflow#2072

Merged
diegolmello merged 12 commits intodevelopfrom
fix.text-overflow
May 8, 2020
Merged

[FIX] Big names overflow#2072
diegolmello merged 12 commits intodevelopfrom
fix.text-overflow

Conversation

@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

@djorkaeffalexandre djorkaeffalexandre commented Apr 28, 2020 •
edited
Loading

@RocketChat/ReactNative

Closes #1978 .

Last update

Screen Shot 2020-05-06 at 09 13 53
Screen Shot 2020-04-30 at 14 54 25
Screen Shot 2020-04-30 at 14 54 08
Screen Shot 2020-04-30 at 14 52 57

RoomsListHeader

Android

Before

Screen Shot 2020-04-28 at 11 02 51

After

Screen Shot 2020-04-28 at 11 02 10

iOS

Before

Screen Shot 2020-04-28 at 11 10 32

After

Screen Shot 2020-04-28 at 10 53 29

SideBarView

Android

Before

Screen Shot 2020-04-28 at 11 11 54

After

Screen Shot 2020-04-28 at 10 53 05

iOS

Before

Screen Shot 2020-04-28 at 10 54 10

After

Screen Shot 2020-04-28 at 10 53 09

ServerDropdown

Before

Screen Shot 2020-04-28 at 11 14 22

After

Screen Shot 2020-04-28 at 10 50 03

RoomInfoView (Direct)

Before

Screen Shot 2020-04-28 at 10 54 03

After

Screen Shot 2020-04-28 at 10 52 21

RoomActionsView

Before

Screen Shot 2020-04-28 at 10 53 59

After

Screen Shot 2020-04-28 at 10 52 13

RoomInfoView (Channel)

Before

Screen Shot 2020-04-28 at 10 53 51

After

Screen Shot 2020-04-28 at 10 51 11

Message Time

Before

Screen Shot 2020-04-28 at 11 41 41

After

Screen Shot 2020-04-28 at 11 40 56

@djorkaeffalexandre @devyaniChoubey
[FIX] Message time
c506c1d 
Co-authored-by: devyaniChoubey <[email protected]>
@djorkaeffalexandre djorkaeffalexandre mentioned this pull request Apr 28, 2020
Closed
diegolmello
diegolmello reviewed Apr 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On both cases, the ellipses should be ending aligned right.
image
image

@diegolmello diegolmello merged commit 66edd7a into develop May 8, 2020
@diegolmello diegolmello deleted the fix.text-overflow branch May 8, 2020 17:09
diegolmello added a commit that referenced this pull request May 25, 2020
@diegolmello @phriedrich
@guilhermesiqueira @Prateek93a @djorkaeffalexandre @devyaniChoubey @ssbing99 @ura14h @Exordian @Daanchaam @youssef-md @ivanape @sarthakpranesh @tanmoyopenroot @hibikine @EzequielDeOliveira @regalstreak @dependabot @GOVINDDIXIT @azhaubassar @zhaubassar @Badal1234 @BrunoOliveiraDantas @CalebeRios
Merge beta into master (#2143