[FIX] Add headers wherever necessary#1937
Closed
regalstreak wants to merge 4 commits intoRocketChat:developfrom
Closed
[FIX] Add headers wherever necessary#1937regalstreak wants to merge 4 commits intoRocketChat:developfrom
regalstreak wants to merge 4 commits intoRocketChat:developfrom
Conversation
Merged
djorkaeffalexandre
changed the title
djorkaeffalexandre
suggested changes
Mar 24, 2020
regalstreak
force-pushed
the
fx-http-auth-headers
branch
2 times, most recently
from
aa92eed to
ad0dd9c
Compare
regalstreak
force-pushed
the
fx-http-auth-headers
branch
from
ad0dd9c to
068b8a5
Compare
Contributor
Author
|
@djorkaeffalexandre have a look, rebased and added headers to the new audio component. Works for me with basic auth now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@djorkaeffalexandre
Closes #1753
More instructions for testing are mentioned on the issue. Added headers wherever necessary. Images, Audio, Video and Files now work with a reverse proxy with nginx basic http auth now