Merged
Conversation
# Conflicts: # .circleci/config.yml # android/build.gradle # app/views/SettingsView/index.js # ios/Podfile # ios/RocketChatRN.xcodeproj/project.pbxproj # package.json # yarn.lock
# Conflicts: # package.json
6 tasks
diegolmello
force-pushed
the
chore-add-bugsnag
branch
from
bcdf2ce to
e8c1ded
Compare
diegolmello
approved these changes
Aug 23, 2019
Member
diegolmello
left a comment
diegolmello
left a comment
There was a problem hiding this comment.
I'm in love with this PR.
Thanks, @IlarionHalushka!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #123
Previous PR for configuring bugsnag was closed because it was created in IlarionHalushka's repository and this new PR is created in Rocket.Chat.ReactNative repo.
This PR aims to add error logging using Bugsnag.
Bugsnag provides ability to upload source maps for each build in order to be able to see an informative stack trace.
Send crash reportsswitch which enables\disables reports\analytics sending.Screenshots of error stack trace on Bugsnag:
Uploaded source maps (release via CI, debug from local machine):
