Skip to content

[FIX] Endless "connecting" on notification tap on iOS#1121

Merged
diegolmello merged 2 commits intodevelopfrom
fix.notification-tap
Aug 9, 2019
Merged

[FIX] Endless "connecting" on notification tap on iOS#1121
diegolmello merged 2 commits intodevelopfrom
fix.notification-tap

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@RocketChat/ReactNative

Turns out react-native-notifications v2 fires notificationOpened event even on cold start.
It was dispatching deepLinkingOpen twice causing selectServerRequest to never finish.

@diegolmello diegolmello merged commit b8d9848 into develop Aug 9, 2019
@diegolmello diegolmello deleted the fix.notification-tap branch August 9, 2019 17:03
@djorkaeffalexandre
Copy link
Copy Markdown
Contributor

Nice! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants