Skip to content

[NEW] SAML authentication support#1108

Merged
diegolmello merged 12 commits intodevelopfrom
new/saml
Aug 9, 2019
Merged

[NEW] SAML authentication support#1108
diegolmello merged 12 commits intodevelopfrom
new/saml

Conversation

@philipbrito
Copy link
Copy Markdown
Contributor

@RocketChat/ReactNative

Closes #428

To be merged after #1093.

@philipbrito philipbrito self-assigned this Aug 6, 2019
# Conflicts:
#	app/lib/rocketchat.js
#	app/views/LoginSignupView.js
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 7, 2019

This pull request introduces 1 alert when merging 1838174 into 6a3523d - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

Copy link
Copy Markdown
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 59426f4 into develop Aug 9, 2019
@diegolmello diegolmello deleted the new/saml branch August 9, 2019 17:28
@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Aug 10, 2019

@diegolmello @filipedelimabrito should we update?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

authentication via SAML is missing

5 participants