[IMPROVEMENT] Notification Preference#1105
Merged
diegolmello merged 19 commits intoRocketChat:developfrom Aug 23, 2019
Merged
Conversation
pranavpandey1998official
changed the title
diegolmello
requested changes
Aug 7, 2019
pranavpandey1998official
added
👀 needs review
and removed
✅ needs tests
🚨 needs changes
labels
diegolmello
requested changes
Aug 19, 2019
|
|
||
| render() { | ||
| const { room } = this.state; | ||
| return ( |
Member
There was a problem hiding this comment.
I'm missing SafeAreaView notch control (take a look at bottom cutting):
Contributor
Author
There was a problem hiding this comment.
its not coming for me
# Conflicts: # app/views/RoomActionsView/index.js
diegolmello
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #1073
I have updated react-native-action-picker to 6.0 because the new version lets us remove the arrow of picker and 6.3 doesn't seems to work on android app doesn't start